Re: [webkit-dev] Incremental steps towards moving WebCore/platform out of WebCore

2011-12-15 Thread Hajime Morrita
One concern is that Platform is too generic to put in global namespace and it might conflict existing symbols from platform SDK or something. But because we already have generic names like ASSERT() and it works, this concern is just a theoretical thing. So if it works with existing platforms, I

Re: [webkit-dev] Incremental steps towards moving WebCore/platform out of WebCore

2011-12-15 Thread Joe Mason
. -Original Message- From: webkit-dev-boun...@lists.webkit.org [mailto:webkit-dev- boun...@lists.webkit.org] On Behalf Of Hajime Morrita Sent: Thursday, December 15, 2011 3:31 AM To: Jarred Nicholls Cc: webkit-dev@lists.webkit.org Subject: Re: [webkit-dev] Incremental steps towards

Re: [webkit-dev] Incremental steps towards moving WebCore/platform out of WebCore

2011-12-15 Thread Darin Adler
The namespace name Platform is OK. I’m concerned that this is over-use of namespace and will make WebCore code overall harder to read. One of the notable features of the classes in the platform directory is that they fit in smoothly and are easy to use in WebCore. Being in the same namespace

Re: [webkit-dev] Incremental steps towards moving WebCore/platform out of WebCore

2011-12-15 Thread Adam Barth
On Thu, Dec 15, 2011 at 8:22 AM, Darin Adler da...@apple.com wrote: The namespace name Platform is OK. I’m concerned that this is over-use of namespace and will make WebCore code overall harder to read. One of the notable features of the classes in the platform directory is that they fit in

Re: [webkit-dev] Incremental steps towards moving WebCore/platform out of WebCore

2011-12-14 Thread Ryosuke Niwa
On Wed, Dec 14, 2011 at 10:55 PM, Adam Barth aba...@webkit.org wrote: It seems like introducing the new namespace before the move would be beneficial because it would help us sort out whatever layering violations we have today (as they'd become apparent because of the explicit mention of the

Re: [webkit-dev] Incremental steps towards moving WebCore/platform out of WebCore

2011-12-14 Thread Jarred Nicholls
On Thu, Dec 15, 2011 at 1:55 AM, Adam Barth aba...@webkit.org wrote: I was working backwards from what's going to be needed to move WebCore/platform out of WebCore, and it occurred to me that we'll probably want a separate namespace for the code once it's outside of WebCore, just like WTF has