Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-07 Thread Alejandro Garcia Castro
On Fri, Feb 04, 2011 at 02:25:10PM -0500, Adam Roben wrote:
 Hi all-
 
 [...]
 
 Please file any bugs you find with this feature on bugs.webkit.org,
 and CC me. Please also file bugs for any ideas you have for making
 this more useful!
 

Nice, we have been running this crash service for the two gtk+ debug
bots for some time now, it has stacks and core files, maybe it is a
good idea if we could also integrate it the same way, if possible:

http://webkit-bots.igalia.com/

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-07 Thread Adam Roben
On Feb 7, 2011, at 7:20 AM, Alejandro Garcia Castro wrote:

 On Fri, Feb 04, 2011 at 02:25:10PM -0500, Adam Roben wrote:
 Hi all-
 
 [...]
 
 Please file any bugs you find with this feature on bugs.webkit.org,
 and CC me. Please also file bugs for any ideas you have for making
 this more useful!
 
 
 Nice, we have been running this crash service for the two gtk+ debug
 bots for some time now, it has stacks and core files, maybe it is a
 good idea if we could also integrate it the same way, if possible:
 
 http://webkit-bots.igalia.com/

You can see how the Mac/Windows ports do it by looking at 
captureSavedCrashLog($) in old-run-webkit-tests.

-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread David Levin
Kudos!


On Fri, Feb 4, 2011 at 11:25 AM, Adam Roben aro...@apple.com wrote:

 Hi all-

 The results.html pages on build.webkit.org now make it much easier to
 triage crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by
 http://webkit.org/b/44135). When a test crashes, you'll see something
 like this on Mac:

 fast/events/tabindex-focus-blur-all.htmlhttp://trac.webkit.org/export/77639/trunk/LayoutTests/fast/events/tabindex-focus-blur-all.html
 stderrhttp://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77639%20(14584)/fast/events/tabindex-focus-blur-all-stderr.txtcrash
 log (com.apple.WebCore:
 JSC::Bindings::Instance::willDestroyRuntimeObject(JSC::Bindings::RuntimeObject*)
 + 
 156)http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77639%20(14584)/fast/events/tabindex-focus-blur-all-crash-log.txt


 …and like this on Windows:

 fast/events/tabindex-focus-blur-all.htmlhttp://trac.webkit.org/export/77636/trunk/LayoutTests/fast/events/tabindex-focus-blur-all.html
 stderrhttp://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r77636%20(24918)/fast/events/tabindex-focus-blur-all-stderr.txtcrash
 log 
 (WebKit!JSC::Bindings::Instance::willDestroyRuntimeObject+95)http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r77636%20(24918)/fast/events/tabindex-focus-blur-all-crash-log.txt


 The new crash log link will take you to a textual crash log for that
 test. The function name you see is our best guess at the crashing module,
 function, and offset (in decimal on Mac, hexadecimal on Windows), based on
 the crash log.

 Please file any bugs you find with this feature on bugs.webkit.org, and CC
 me. Please also file bugs for any ideas you have for making this more
 useful!

 -Adam


 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben

On Feb 4, 2011, at 2:25 PM, Adam Roben wrote:

 The new crash log link will take you to a textual crash log for that test.

And on Windows, the crashing line of code is even included in the log, like 
this:

 FAULTING_SOURCE_CODE:  
105: 
106: void Instance::willDestroyRuntimeObject(RuntimeObject* object)
107: {
108: ASSERT(m_rootObject);
   109: ASSERT(m_rootObject-isValid());
110: m_rootObject-removeRuntimeObject(object);
111: m_runtimeObject.clear(object);
112: }
113: 
114: void Instance::willInvalidateRuntimeObject(RuntimeObject* object)

-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Jerome Duval
Seems like a nice feature. Why the different bases for the offsets 
between Mac and Windows?


On 11-02-04 02:25 PM, Adam Roben wrote:

Hi all-

The results.html pages on build.webkit.org http://build.webkit.org 
now make it much easier to triage crashing tests on Mac and Windows XP 
(Windows Vista/7 are blocked by http://webkit.org/b/44135). When a 
test crashes, you'll see something like this on Mac:


fast/events/tabindex-focus-blur-all.html 
http://trac.webkit.org/export/77639/trunk/LayoutTests/fast/events/tabindex-focus-blur-all.html 
	stderr 
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77639%20%2814584%29/fast/events/tabindex-focus-blur-all-stderr.txt 
	crash log (|com.apple.WebCore: 
JSC::Bindings::Instance::willDestroyRuntimeObject(JSC::Bindings::RuntimeObject*) 
+ 156|) 
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77639%20%2814584%29/fast/events/tabindex-focus-blur-all-crash-log.txt




…and like this on Windows:

fast/events/tabindex-focus-blur-all.html 
http://trac.webkit.org/export/77636/trunk/LayoutTests/fast/events/tabindex-focus-blur-all.html 
	stderr 
http://build.webkit.org/results/Windows%20XP%20Debug%20%28Tests%29/r77636%20%2824918%29/fast/events/tabindex-focus-blur-all-stderr.txt 
	crash log 
(|WebKit!JSC::Bindings::Instance::willDestroyRuntimeObject+95|) 
http://build.webkit.org/results/Windows%20XP%20Debug%20%28Tests%29/r77636%20%2824918%29/fast/events/tabindex-focus-blur-all-crash-log.txt 





The new crash log link will take you to a textual crash log for that 
test. The function name you see is our best guess at the crashing 
module, function, and offset (in decimal on Mac, hexadecimal on 
Windows), based on the crash log.


Please file any bugs you find with this feature on bugs.webkit.org 
http://bugs.webkit.org, and CC me. Please also file bugs for any 
ideas you have for making this more useful!


-Adam

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Adam Roben
On Feb 4, 2011, at 3:29 PM, Jerome Duval wrote:

 Seems like a nice feature. Why the different bases for the offsets between 
 Mac and Windows?

That's just how the offsets are represented by default in each platform's crash 
logs. It shouldn't be hard to convert to a common base, though. Feel free to 
file a bug!

-Adam

 On 11-02-04 02:25 PM, Adam Roben wrote:
 
 Hi all-
 
 The results.html pages on build.webkit.org now make it much easier to triage 
 crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by 
 http://webkit.org/b/44135). When a test crashes, you'll see something like 
 this on Mac:
 
 fast/events/tabindex-focus-blur-all.htmlstderr  crash log 
 (com.apple.WebCore: 
 JSC::Bindings::Instance::willDestroyRuntimeObject(JSC::Bindings::RuntimeObject*)
  + 156)
 
 …and like this on Windows:
 
 fast/events/tabindex-focus-blur-all.htmlstderr  crash log 
 (WebKit!JSC::Bindings::Instance::willDestroyRuntimeObject+95)
 
 The new crash log link will take you to a textual crash log for that test. 
 The function name you see is our best guess at the crashing module, 
 function, and offset (in decimal on Mac, hexadecimal on Windows), based on 
 the crash log.
 
 Please file any bugs you find with this feature on bugs.webkit.org, and CC 
 me. Please also file bugs for any ideas you have for making this more useful!
 
 -Adam
 
 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] More information for crashing tests now available on build.webkit.org

2011-02-04 Thread Jerome Duval
Rethinking about it, I don't really care that the bases are different. I 
care that the Windows base is different from what I would expect.


I filed bug 53803 https://bugs.webkit.org/show_bug.cgi?id=53803 about it.

Jerome

On 11-02-04 03:29 PM, Adam Roben wrote:

On Feb 4, 2011, at 3:29 PM, Jerome Duval wrote:

Seems like a nice feature. Why the different bases for the offsets 
between Mac and Windows?


That's just how the offsets are represented by default in each 
platform's crash logs. It shouldn't be hard to convert to a common 
base, though. Feel free to file a bug!


-Adam


On 11-02-04 02:25 PM, Adam Roben wrote:

Hi all-

The results.html pages on build.webkit.org 
http://build.webkit.org/ now make it much easier to triage 
crashing tests on Mac and Windows XP (Windows Vista/7 are blocked by 
http://webkit.org/b/44135). When a test crashes, you'll see 
something like this on Mac:


fast/events/tabindex-focus-blur-all.html 
http://trac.webkit.org/export/77639/trunk/LayoutTests/fast/events/tabindex-focus-blur-all.html 
	stderr 
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77639%20%2814584%29/fast/events/tabindex-focus-blur-all-stderr.txt 
	crash log (|com.apple.WebCore: 
JSC::Bindings::Instance::willDestroyRuntimeObject(JSC::Bindings::RuntimeObject*) 
+ 156|) 
http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r77639%20%2814584%29/fast/events/tabindex-focus-blur-all-crash-log.txt




…and like this on Windows:

fast/events/tabindex-focus-blur-all.html 
http://trac.webkit.org/export/77636/trunk/LayoutTests/fast/events/tabindex-focus-blur-all.html 
	stderr 
http://build.webkit.org/results/Windows%20XP%20Debug%20%28Tests%29/r77636%20%2824918%29/fast/events/tabindex-focus-blur-all-stderr.txt 
	crash log 
(|WebKit!JSC::Bindings::Instance::willDestroyRuntimeObject+95|) 
http://build.webkit.org/results/Windows%20XP%20Debug%20%28Tests%29/r77636%20%2824918%29/fast/events/tabindex-focus-blur-all-crash-log.txt 





The new crash log link will take you to a textual crash log for 
that test. The function name you see is our best guess at the 
crashing module, function, and offset (in decimal on Mac, 
hexadecimal on Windows), based on the crash log.


Please file any bugs you find with this feature on bugs.webkit.org 
http://bugs.webkit.org/, and CC me. Please also file bugs for any 
ideas you have for making this more useful!


-Adam


___
webkit-dev mailing list
webkit-dev@lists.webkit.org mailto:webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev