Re: [webkit-dev] NRWT Migration Update
The WK2 bot looks stable (possibly more stable than before) after the NRWT switchover: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98091%20(15558)/results.html I'll work on switching the --leaks bot back to NRWT next week, and then the only remaining builder to switch is Apple's Windows. (I likely won't be able to takle that one myself.) Thanks again for your patience in this process. -eric On Thu, Oct 20, 2011 at 9:54 PM, Eric Seidel e...@webkit.org wrote: After further testing tonight, I was able to reproduce the exact set of 81 WebKit 2 failures with both NRWT and ORWT this evening. I'm going to move the bots to NRWT shortly. -eric On Wed, Oct 19, 2011 at 9:59 PM, Eric Seidel e...@webkit.org wrote: After a long hiatus, I'm back working on NRWT. As of this evening all of the blocking issues to switching the WK2 bot are resolved: https://bugs.webkit.org/show_bug.cgi?id=56729 Just waiting for the WK2 bot to have some smaller number of failures, then I'll pull the trigger. After WK2 is switched to NRWT, there is only --leaks and Windows to switch, before we can consider deleting ORWT. Interested parties can continue to track the NRWT migration here: https://bugs.webkit.org/show_bug.cgi?id=34984 -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
Hi Eric, Can you please inform us, what are the major difference between NRWT and ORWT. I think it would of lot help for people like me who worked on ORWT long back and now to catch up with NRWT. Thanks a lot in anticipation. -Sravan. On Fri, Oct 21, 2011 at 5:03 PM, Eric Seidel e...@webkit.org wrote: The WK2 bot looks stable (possibly more stable than before) after the NRWT switchover: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98091%20(15558)/results.htmlhttp://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r98091%20%2815558%29/results.html I'll work on switching the --leaks bot back to NRWT next week, and then the only remaining builder to switch is Apple's Windows. (I likely won't be able to takle that one myself.) Thanks again for your patience in this process. -eric On Thu, Oct 20, 2011 at 9:54 PM, Eric Seidel e...@webkit.org wrote: After further testing tonight, I was able to reproduce the exact set of 81 WebKit 2 failures with both NRWT and ORWT this evening. I'm going to move the bots to NRWT shortly. -eric On Wed, Oct 19, 2011 at 9:59 PM, Eric Seidel e...@webkit.org wrote: After a long hiatus, I'm back working on NRWT. As of this evening all of the blocking issues to switching the WK2 bot are resolved: https://bugs.webkit.org/show_bug.cgi?id=56729 Just waiting for the WK2 bot to have some smaller number of failures, then I'll pull the trigger. After WK2 is switched to NRWT, there is only --leaks and Windows to switch, before we can consider deleting ORWT. Interested parties can continue to track the NRWT migration here: https://bugs.webkit.org/show_bug.cgi?id=34984 -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Living for the unseen and undone ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
On Oct 21, 2011, at 7:33 AM, Eric Seidel wrote: The WK2 bot looks stable (possibly more stable than before) after the NRWT switchover: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98091%20(15558)/results.html Awesome! I'll work on switching the --leaks bot back to NRWT next week, and then the only remaining builder to switch is Apple's Windows. (I likely won't be able to takle that one myself.) I will hopefully be able to help get Windows switched over. -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
On Oct 21, 2011, at 9:41 AM, SravanKumar Sandela wrote: Can you please inform us, what are the major difference between NRWT and ORWT. I think it would of lot help for people like me who worked on ORWT long back and now to catch up with NRWT. This page gives a good explanation: http://trac.webkit.org/wiki/NewRunWebKitTests -Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
I would recommend all ports who haven't switched to ORWT do so. NRWT is currently a white-list, see: http://trac.webkit.org/browser/trunk/Tools/Scripts/run-webkit-tests#L66 but soon it will be a black-list, or no list at all. Ports should use NRWT. If any port is having trouble, I'm *happy* to help fix things. :) -eric On Fri, Oct 21, 2011 at 12:52 PM, Antonio Gomes toniki...@gmail.com wrote: Hi Eric. So does it it mean that any being upstream'ed port which was also providing a ORWT based bot, should actually switch to NRWT instead? Cheers, On Thu, Oct 20, 2011 at 12:59 AM, Eric Seidel e...@webkit.org wrote: After a long hiatus, I'm back working on NRWT. As of this evening all of the blocking issues to switching the WK2 bot are resolved: https://bugs.webkit.org/show_bug.cgi?id=56729 Just waiting for the WK2 bot to have some smaller number of failures, then I'll pull the trigger. After WK2 is switched to NRWT, there is only --leaks and Windows to switch, before we can consider deleting ORWT. Interested parties can continue to track the NRWT migration here: https://bugs.webkit.org/show_bug.cgi?id=34984 -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- --Antonio Gomes ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
On Fri, Oct 21, 2011 at 12:59 PM, Eric Seidel e...@webkit.org wrote: I would recommend all ports who haven't switched to ORWT do so. You presumably mean that you recommend all ports who haven't switched to *NRWT* do so :) Also, I would like to see us start working on turning on parallel tests on the bots once everyone is cut over. It is a big speed improvement (and we do run them in parallel on the Chromium bots). Recently I was doing some testing on a 48-core linux box, and we got a near-linear speed up over the 4-core box we had to compare it to (which itself is a near-linear speed up over running in a single thread) ... it really does work. And it is definitely true that the tests are flakier when run in parallel, but perhaps this'll give us the impetus to fix them :). I am also more than happy to field any questions about moving to NRWT or hacking on it to add features. -- Dirk ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
On Fri, Oct 21, 2011 at 2:03 PM, Dirk Pranke dpra...@chromium.org wrote: On Fri, Oct 21, 2011 at 12:59 PM, Eric Seidel e...@webkit.org wrote: I would recommend all ports who haven't switched to ORWT do so. You presumably mean that you recommend all ports who haven't switched to *NRWT* do so :) Also, I would like to see us start working on turning on parallel tests on the bots once everyone is cut over. It is a big speed improvement (and we do run them in parallel on the Chromium bots). Recently I was doing some testing on a 48-core linux box, and we got a near-linear speed up over the 4-core box we had to compare it to (which itself is a near-linear speed up over running in a single thread) ... it really does work. And it is definitely true that the tests are flakier when run in parallel, but perhaps this'll give us the impetus to fix them :). I am also more than happy to field any questions about moving to NRWT or hacking on it to add features. That's mostly a matter of tweaking the wrapper script. We can experiment with rolling it out gradually across the build farm. Adam ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
Hi Eric and Roben, Thanks a lot for the description and link. -Sravan On Fri, Oct 21, 2011 at 10:59 PM, Eric Seidel e...@webkit.org wrote: I didn't even know that page existed. :) NRWT is Python. It's split into many files. It is part of webkitpy (which is our python library for dealing with webkit). NRWT was written independently (over several years) at Google. It predates webkitpy, but it now lives as part of webkitpy: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests but it doesn't fit 100% into the webkitpy model (it's not a Command subclass, it doesn't have a Host object) so hacking on it can be slightly confusing. As a port author the files of most interest to you are likely the Port subclasses: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port qt.pyhttp://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port%0Aqt.py, gtk.py, etc. I'm happy to answer any and all questions as they come up. http://trac.webkit.org/browser/trunk/Tools/Scripts/run-webkit-tests is still the preferred way to run the tests. Eventually that wrapper will be deleted and replaced with NRWT directly. Until then, it is smart enough to run ORWT vs NRWT depending on the platform and configuration. Also, although NRWT supports running tests in parallel, we have that feature disabled by default when run from run-webkit-tests. Running tests in parallel can cause some tests to flake. If you're developing on your local machine and don't care about possible flakes, just want the fastest test run possible, it's best to run new-run-webkit-tests directly for now. -eric On Fri, Oct 21, 2011 at 6:41 AM, SravanKumar Sandela sravan@gmail.com wrote: Hi Eric, Can you please inform us, what are the major difference between NRWT and ORWT. I think it would of lot help for people like me who worked on ORWT long back and now to catch up with NRWT. Thanks a lot in anticipation. -Sravan. On Fri, Oct 21, 2011 at 5:03 PM, Eric Seidel e...@webkit.org wrote: The WK2 bot looks stable (possibly more stable than before) after the NRWT switchover: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/r98091%20(15558)/results.htmlhttp://build.webkit.org/results/SnowLeopard%20Intel%20Release%20%28WebKit2%20Tests%29/r98091%20%2815558%29/results.html I'll work on switching the --leaks bot back to NRWT next week, and then the only remaining builder to switch is Apple's Windows. (I likely won't be able to takle that one myself.) Thanks again for your patience in this process. -eric On Thu, Oct 20, 2011 at 9:54 PM, Eric Seidel e...@webkit.org wrote: After further testing tonight, I was able to reproduce the exact set of 81 WebKit 2 failures with both NRWT and ORWT this evening. I'm going to move the bots to NRWT shortly. -eric On Wed, Oct 19, 2011 at 9:59 PM, Eric Seidel e...@webkit.org wrote: After a long hiatus, I'm back working on NRWT. As of this evening all of the blocking issues to switching the WK2 bot are resolved: https://bugs.webkit.org/show_bug.cgi?id=56729 Just waiting for the WK2 bot to have some smaller number of failures, then I'll pull the trigger. After WK2 is switched to NRWT, there is only --leaks and Windows to switch, before we can consider deleting ORWT. Interested parties can continue to track the NRWT migration here: https://bugs.webkit.org/show_bug.cgi?id=34984 -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev -- Living for the unseen and undone -- Living for the unseen and undone ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
Re: [webkit-dev] NRWT Migration Update
After further testing tonight, I was able to reproduce the exact set of 81 WebKit 2 failures with both NRWT and ORWT this evening. I'm going to move the bots to NRWT shortly. -eric On Wed, Oct 19, 2011 at 9:59 PM, Eric Seidel e...@webkit.org wrote: After a long hiatus, I'm back working on NRWT. As of this evening all of the blocking issues to switching the WK2 bot are resolved: https://bugs.webkit.org/show_bug.cgi?id=56729 Just waiting for the WK2 bot to have some smaller number of failures, then I'll pull the trigger. After WK2 is switched to NRWT, there is only --leaks and Windows to switch, before we can consider deleting ORWT. Interested parties can continue to track the NRWT migration here: https://bugs.webkit.org/show_bug.cgi?id=34984 -eric ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev
