Re: [webkit-dev] Proposal to enable logging under non-systemd linux distros

2021-10-21 Thread Pablo Correa Gomez via webkit-dev
On Tue, 2021-10-19 at 19:32 -0500, Michael Catanzaro wrote:
> On Wed, Oct 20 2021 at 02:07:56 AM +0200, Pablo Correa Gomez via 
> webkit-dev  wrote:
> >  - Rename USE_SYSTEMD to USE_JOURNALD and have a conditional check
> > which looks for elogind if libsystemd is not found, similar to the 
> > hack
> > I used for proof-testing.
> 
> This one! Do this one! We don't need two different build options for 
> systemd vs. elogind, when all we really care about is whether the 
> journald API is available.

Thank you very much! I opened a bug and sent a patch: 
https://bugs.webkit.org/show_bug.cgi?id=232080 I apologize if there any
obvious bug, first time contributing to this project and I am still a
bit lost.

> Michael
> 
> P.S. (We might also consider adding an environment variable to
> redirect 
> all log messages to stderr. This is *almost* possible now after 
> https://trac.webkit.org/changeset/283469/webkit, but requires more 
> playing with the #if guards. Don't worry about this if you're not 
> interested in working on it. I just mention it in case that sounds
> like 
> your idea of an exciting project. ;)
> 

Unfortunately this a bit far beyond what I can do. But sounds like a
great idea if it ever gets implemented :) Thank you very much for the
good work in this project!

Pablo Correa Gómez.

___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev


Re: [webkit-dev] Proposal to enable logging under non-systemd linux distros

2021-10-19 Thread Michael Catanzaro via webkit-dev
On Wed, Oct 20 2021 at 02:07:56 AM +0200, Pablo Correa Gomez via 
webkit-dev  wrote:

 - Rename USE_SYSTEMD to USE_JOURNALD and have a conditional check
which looks for elogind if libsystemd is not found, similar to the 
hack

I used for proof-testing.


This one! Do this one! We don't need two different build options for 
systemd vs. elogind, when all we really care about is whether the 
journald API is available.


Michael

P.S. (We might also consider adding an environment variable to redirect 
all log messages to stderr. This is *almost* possible now after 
https://trac.webkit.org/changeset/283469/webkit, but requires more 
playing with the #if guards. Don't worry about this if you're not 
interested in working on it. I just mention it in case that sounds like 
your idea of an exciting project. ;)



___
webkit-dev mailing list
webkit-dev@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-dev