Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff

2012-06-18 Thread Elliot Poger
Food for thought... Skia's skdiff tool generates two diff images for each image pair: - 1. every pixel which is different at all between images 1 2 shows up as white - 2. every pixel shows the color difference between images 1 2 (much more subtle) For an example of what this looks

Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff

2012-06-15 Thread Ryosuke Niwa
On Fri, Jun 15, 2012 at 4:24 PM, Tony Payne tpa...@chromium.org wrote: I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel is marked as 100% red. I'd like to change it so that miniscule difference

Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff

2012-06-15 Thread Tony Payne
On Fri, Jun 15, 2012 at 4:27 PM, Ryosuke Niwa rn...@webkit.org wrote: On Fri, Jun 15, 2012 at 4:24 PM, Tony Payne tpa...@chromium.org wrote: I would like to change chromium's ImageDiff to reflect the magnitude of pixel changes. Currently, if the pixel has any difference, the entire pixel is

Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff

2012-06-15 Thread Leandro Pereira
On Fri, Jun 15, 2012 at 8:24 PM, Tony Payne tpa...@chromium.org wrote: Looking at the code for CG, gtk and Win versions of ImageDiff, I think they already do something similar. Is this correct? The GTK and Efl produces a grayscale image, where the pixel goes from black (no difference) to white,

Re: [webkit-dev] Reflecting pixel delta distance in ImageDiff

2012-06-15 Thread Leandro Pereira
On Fri, Jun 15, 2012 at 8:27 PM, Ryosuke Niwa rn...@webkit.org wrote: People with Protanomaly like myself won't be too happy about it. I'm already having a really hard time finding the red pixels on diffs without zooming. Perhaps generating a list of rectangles where there are differences would