Re: [webkit-dev] Running WebGL layout tests

2009-11-11 Thread Chris Marrin


On Nov 3, 2009, at 12:35 PM, Kenneth Russell wrote:


Hi,

Trying to run the WebGL layout tests in LayoutTests/fast/canvas/webgl.
Here's the command line I'm using:

run-webkit-tests --debug LayoutTests/fast/canvas/webgl/[test  
name.html]


(I built WebKit --debug.)

All of the tests fail while attempting to fetch the 3D context.
(TypeError: Result of expression 'context' [undefined] is not an
object.) The same tests run fine when run under run-safari --debug.

Do I need to do some other defaults write or other setup to allow
the layout test harness to run with WebGL enabled?



So you're saying that the overridePreferences() call is no longer  
turning on the WebKitWebGLEnabled flag in DRT? That's what should  
turn on the option. What happens if you run:


defaults write com.apple.Safari WebKitWebGLEnabled -bool YES

and then run layout tests?

-
~Chris
cmar...@apple.com




___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev


Re: [webkit-dev] Running WebGL layout tests

2009-11-11 Thread Kenneth Russell
On Wed, Nov 11, 2009 at 7:31 AM, Chris Marrin cmar...@apple.com wrote:

 On Nov 3, 2009, at 12:35 PM, Kenneth Russell wrote:

 Hi,

 Trying to run the WebGL layout tests in LayoutTests/fast/canvas/webgl.
 Here's the command line I'm using:

 run-webkit-tests --debug LayoutTests/fast/canvas/webgl/[test name.html]

 (I built WebKit --debug.)

 All of the tests fail while attempting to fetch the 3D context.
 (TypeError: Result of expression 'context' [undefined] is not an
 object.) The same tests run fine when run under run-safari --debug.

 Do I need to do some other defaults write or other setup to allow
 the layout test harness to run with WebGL enabled?


 So you're saying that the overridePreferences() call is no longer turning on
 the WebKitWebGLEnabled flag in DRT? That's what should turn on the option.
 What happens if you run:

    defaults write com.apple.Safari WebKitWebGLEnabled -bool YES

 and then run layout tests?

This is working fine now since
https://bugs.webkit.org/show_bug.cgi?id=31088 is fixed.

defaults write com.apple.Safari WebKitWebGLEnabled -bool YES has no
effect on DumpRenderTree.

-Ken
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev