Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2020-04-20 Thread Maciej Stachowiak
Looking at my old email, I think it’s worth supporting for Mail clients for example, but I think it would require some OS-level engineering as well to have it work on macOS. (Other Apple platforms currently don’t support customizing the default mail client). And I do still think that allow

Re: [webkit-dev] Support "registerProtocolHandler" in WebKit2

2020-04-20 Thread Frédéric Wang
Hi, I'm just bumping this old thread, not because I plan to implement it but because I was mentioning it on slack the other day and realized not everybody is #standards: https://webkit.slack.com/archives/CTY7Z24RZ/p1587142539064000 In particular, my question was related to safelist VS blocklist

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-07-06 Thread Brady Eidson
On Jul 1, 2015, at 7:42 PM, Gyuyoung Kim gyuyoung@webkit.org wrote: WebKit2 already has a similar feature, which is so-called *custom protocol* enabled by Mac, Gtk and EFL ports. However the custom protocol feature supports to register custom scheme through API layer instead of

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-07-06 Thread Gyuyoung Kim
The custom protocol handler feature of the WebKit2 API is for the embedding native application to provide raw data to resource loads directly. While tangentially related to how registerProtocolHandler would work for some uses, there’s numerous differences. If so, custom protocol handler feature

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-07-04 Thread Sam Weinig
(Sorry, had this sitting in my drafts). My concern with the registerProtocolHandler() API is that it complicates an already the very complicated area of custom protocols and a good implementation requires configuration UI (to choose which of potentially multiple apps/websites you want a

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-15 Thread Gyuyoung Kim
On Mon, Jun 8, 2015 at 9:39 AM, Darin Adler da...@apple.com wrote: Sam, Anders, you haven’t replied to the thread since Maciej made his remarks two weeks ago. He asked what you dislike about the API. It seems that some people hope to listen why you guys dislike about this API as well as I

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-10 Thread Gyuyoung Kim
On Mon, Jun 8, 2015 at 12:02 PM, Michael Catanzaro mcatanz...@igalia.com wrote: On Sun, 2015-06-07 at 17:39 -0700, Darin Adler wrote: As one next step in the discussion, is there anyone that wants to present a use case for a protocol other than mailto? irc:// would be useful for those who

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-07 Thread Michael Catanzaro
On Sun, 2015-06-07 at 17:39 -0700, Darin Adler wrote: As one next step in the discussion, is there anyone that wants to present a use case for a protocol other than mailto? irc:// would be useful for those who don't like desktop clients. ___

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-07 Thread Gyuyoung Kim
In order to support the use case on Epiphany browser, we need to support this feature on WK2 first. Besides, as far as I know, EFL browser will have similar use-case by using this feature. Thus, in my humble opinion, similar use cases can be more required in near future. Gyuyoung. On Tue, Jun 2,

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-07 Thread Darin Adler
Are we making progress in this discussion? Maciej stated that he thinks this is useful for mailto and I think that Gyuyoung Kim and Michael Catanzaro stated that they want to do this. As one next step in the discussion, is there anyone that wants to present a use case for a protocol other than

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-06-02 Thread Michael Catanzaro
On Wed, 2015-05-20 at 10:31 +0900, Gyuyoung Kim wrote: I would like to listen what do you think to support 'registerProtocolHandler' in WebKit2. This feature is to execute web content through registered custom protocol. Hi, I think this would be useful for GNOME. One of our goals is for

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-26 Thread Gyuyoung Kim
It seem to me there are both agreements and objections to support this feature in WebKit2. It looks many web contents have already used some custom schemes as 'mailto://', and In my humble opinion, the feature will be able to improve the usage of the custom scheme. Besides we can control the

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-22 Thread Anne van Kesteren
On Fri, May 22, 2015 at 1:50 PM, Gyuyoung Kim gyuyoung@webkit.org wrote: I also don't want to support the content handler feature at the moment. The feature might be more clear and mature. The patch of Bug 92749 only supports registerProtocolHandler, and unregisterProtocolHandler and

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-22 Thread Anne van Kesteren
On Fri, May 22, 2015 at 6:43 PM, Gyuyoung Kim gyuyoung@webkit.org wrote: Current implementation doesn't hook to HTML's navigation directly. We delegate the html navigation(or call native application) to application. Application is able to decide to navigate the given html page or execute

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-22 Thread Gyuyoung Kim
Hi Anne, I need to verify the behaviour using the patch though, I think the registered URL isn't fetched under current patch of Bug 92749. However I need to check if the registered URL is passed to application under the patch's implementation. If this feature will be landed to WK2, it would be

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-22 Thread Gyuyoung Kim
Quickly scanning the bug I couldn't figure out whether you added hooks to HTML's navigate algorithm or Fetch' fetch algorithm. In particular, see the discussion in this bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24091 My personal opinion is that these schemes should only have an

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-22 Thread Gyuyoung Kim
Quickly scanning the bug I couldn't figure out whether you added hooks to HTML's navigate algorithm or Fetch' fetch algorithm. In particular, see the discussion in this bug: https://www.w3.org/Bugs/Public/show_bug.cgi?id=24091 My personal opinion is that these schemes should only have an

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Benjamin Poulain
Looks llke nobody objects. Please make sure to #ifdef everything and disable the feature on OS X and iOS. What is your plan for testing? On 5/19/15 6:31 PM, Gyuyoung Kim wrote: Hello, I would like to listen what do you think to support 'registerProtocolHandler' in WebKit2. This feature is

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Gyuyoung Kim
Hi Benjamin, Looks llke nobody objects. Please make sure to #ifdef everything and disable the feature on OS X and iOS. Ok, let me add #ifdef guard for WK2 ports which don't use this feature. There are already basic test cases for this feature. But I think this isn't enough to test all use

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Gyuyoung Kim
Hi Anders, yes, Sam didn't like to support this feature. However, as I said, I think this feature has been shipped by Firefox and Chrome browsers. Besides It seems to me that web application will need to use this feature in near future. However I know we can't support new feature without WK2

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Anne van Kesteren
On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson ander...@apple.com wrote: Sam Weinig 2015-05-15 10:12:54 PDT: Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not something we want to support in WebKit2 at this time as we are not confident it is a good Web API.

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Gyuyoung Kim
On the face of it, the registerProtocolHandler API seems more general than necessary, but the actual spec for it has a whitelist of specific schemes, most of which seem reasonable for this kind of purpose: https://html.spec.whatwg.org/#custom-handlers Yes, the custom-handlers specification only

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Maciej Stachowiak
On May 21, 2015, at 7:38 PM, Anne van Kesteren ann...@annevk.nl wrote: On Fri, May 22, 2015 at 1:25 AM, Anders Carlsson ander...@apple.com wrote: Sam Weinig 2015-05-15 10:12:54 PDT: Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not something we want to support

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Anne van Kesteren
On Fri, May 22, 2015 at 12:26 PM, Maciej Stachowiak m...@apple.com wrote: (I am more dubious of the content handler aspect.) Agreed, especially as it requires the service to download the resource again. For that use case we need something smarter where you can pass along an object/stream of

Re: [webkit-dev] Support registerProtocolHandler in WebKit2

2015-05-21 Thread Anders Carlsson
On May 20, 2015, at 11:32 PM, Benjamin Poulain benja...@webkit.org wrote: Looks llke nobody objects. That’s not true. From the bug: Sam Weinig mailto:s...@webkit.org 2015-05-15 10:12:54 PDT Support for navigator.registerProtocolHandler/unregisterProtocolHandler is not something we want to