Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Ryosuke Niwa
On Tue, Feb 5, 2019 at 5:06 PM Michael Catanzaro wrote: > On Tue, Feb 5, 2019 at 4:01 PM, ross.kirsl...@sony.com wrote: > > That said, I would expect specifically the Tools/TestWebKitAPI/Tests > > subdirectory to be the thing moved to APITests/, since the code that > > actually runs the tests is

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Michael Catanzaro
On Tue, Feb 5, 2019 at 4:01 PM, ross.kirsl...@sony.com wrote: That said, I would expect specifically the Tools/TestWebKitAPI/Tests subdirectory to be the thing moved to APITests/, since the code that actually runs the tests is as much a “tool” as DRT, WKTR, or various other test-running

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Brian Burg
I am in favor of a top-level Tests directory which would contain the various *Tests/ directories within it. Any relative directory paths (i.e.,

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Ross . Kirsling
: Tuesday, February 5, 2019 at 1:44 PM To: "Kirsling, Ross" Cc: Michael Catanzaro , WebKit Development Subject: Re: [webkit-dev] Tools/TestWebKitAPI Moving it to top-level APITests directory sounds good to me although I'm not volunteering to fix any Xcode or Apple internal build related is

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Ryosuke Niwa
Moving it to top-level APITests directory sounds good to me although I'm not volunteering to fix any Xcode or Apple internal build related issues. - R. Niwa On Tue, Feb 5, 2019 at 1:07 PM wrote: > APITests/ would seem like an improvement to me...although given that this > would be the seventh

Re: [webkit-dev] Tools/TestWebKitAPI

2019-02-05 Thread Ross . Kirsling
APITests/ would seem like an improvement to me...although given that this would be the seventh *Tests/ directly, it also makes me wonder if those should all be moved under a top-level Tests/ directory? __ (Either way, I'd be happy to help with Xcode rearranging if needed, at least to the point