Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
In addition to what Darin said, I think using a consistent name makes the most sense. If “Internal” is what we would use for some of the places we should use it everywhere. Cheers, Keith > On Aug 29, 2017, at 5:29 PM, Darin Adler wrote: > >> On Aug 29, 2017, at 4:32 PM,

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Ryosuke Niwa
On Tue, Aug 29, 2017 at 2:14 PM, Keith Miller wrote: > > >> On Aug 29, 2017, at 11:37 AM, Maciej Stachowiak wrote: >> >> >> >>> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: >>> >>> Sent from my iPhone >>> On Aug 29, 2017, at

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 11:37 AM, Maciej Stachowiak wrote: > > > >> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: >> >> Sent from my iPhone >> >>> On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: >>> >>> I doubt anyone is going

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Michael Catanzaro
On Tue, Aug 29, 2017 at 1:37 PM, Maciej Stachowiak wrote: I tend to agree with this. I think keeping names of static functions globally unique is reasonable, so long as we have an automated way to check. This seems better than namespaces. With namespaces, it's still possible

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Maciej Stachowiak
> On Aug 29, 2017, at 11:31 AM, Darin Adler wrote: > > Sent from my iPhone > >> On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: >> >> I doubt anyone is going to run such a script before they go to upload a >> patch to bugzilla. > > EWS was what

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
Sent from my iPhone > On Aug 29, 2017, at 11:22 AM, Keith Miller wrote: > > I doubt anyone is going to run such a script before they go to upload a > patch to bugzilla. EWS was what I was hoping for; likely to be sufficient. But it could also be integrated into the

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 10:15 AM, Darin Adler wrote: > > If we decide that we can’t support file scope identifiers then we should > figure out the most practical way to do it. Of course this affects constants > and variables, too, not just functions. > > I think this special

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
If we decide that we can’t support file scope identifiers then we should figure out the most practical way to do it. Of course this affects constants and variables, too, not just functions. I think this special FILENAME namespace isn’t all that helpful or needed. If a file contains a class

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Keith Miller
> On Aug 29, 2017, at 9:04 AM, Chris Dumez wrote: > > I indeed think this will require “using” statements or explicit namespace at > call sites. Yeah, this is basically what’s required. Unfortunately, if you ‘using namespace’ in a namespace all subsequent copies of that

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Chris Dumez
I indeed think this will require “using” statements or explicit namespace at call sites. I don’t think anonymous namespaces are suitable for resolving naming conflicts due to unity builds since the functions and up in the same compilation unit. --  Chris Dumez > On Aug 29, 2017, at 9:00

Re: [webkit-dev] Unified source builds: A new rule for static variables

2017-08-29 Thread Darin Adler
How does this work? Without a “using” how does it know to search this namespace? Is this superior to using anonymous namespaces instead of “static”? — Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org