Re: [webkit-dev] Using commit-queue doesn't mean you can use build failures

[Hajime Morrita]

(from the right address...)
Hi,

I don't think it is a reasonable expectation especially for non-chromium
developers.

It is possible for a change to break chromium-linux, chromium-win or
chromium-mac,
that means developers needs to have Linux, Mac and Windows machines to
ensure
the successful build since there is no EWS for these configurations.

More reasonable baseline would be getting all EWS builds green
and/or watching the tree until landed patch goes green. And in my
understanding, these are in fact our current norm.

Regards,
--
morrita


On Thu, Jul 19, 2012 at 3:59 PM, Ryosuke Niwa rn...@webkit.org wrote:

 Hi all,

 Using commit-queue doesn't pardon a committer from causing build failures.

 Notice that the commit queue only builds  runs tests on Chromium Linux
 port. Thus, any build failure that doesn't manifest itself on Chromium
 Linux port — namely any JSC-specific or Windows/Mac specific build
 failures — won't be caught.

 The current policy specifically says the committer is responsible for
 making sure his or her patch builds  passes tests:
 http://www.webkit.org/coding/contributing.html

 So please make sure your patch at least builds if you're landing a patch
 via commit queue.

 Best,
 Ryosuke Niwa
 Software Engineer
 Google Inc.



 ___
 webkit-dev mailing list
 webkit-dev@lists.webkit.org
 http://lists.webkit.org/mailman/listinfo/webkit-dev


___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] Using commit-queue doesn't mean you can use build failures

[Ryosuke Niwa]

On Thu, Jul 19, 2012 at 12:39 AM, Hajime Morrita morr...@chromium.orgwrote:

 It is possible for a change to break chromium-linux, chromium-win or
 chromium-mac,
 that means developers needs to have Linux, Mac and Windows machines to
 ensure
 the successful build since there is no EWS for these configurations.


Sure, I'm not asking them to locally build their patches on every single
port configuration.

More reasonable baseline would be getting all EWS builds green
 and/or watching the tree until landed patch goes green. And in my
 understanding, these are in fact our current norm.


This is exactly what I'm asking.  If you're landing a patch, you should
be at least responsible for making sure things build.  It's unreasonable
for someone to claim that build failure isn't his or her fault just because
he or she used the commit queue.

- Ryosuke
___
webkit-dev mailing list
webkit-dev@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-dev