Re: [webkit-dev] WebCore/platform standalone library

Don and I have implemented this at https://bugs.webkit.org/show_bug.cgi?id=143358 I think we're all ready to go! Reviews welcome! (mcatanzaro: feel free to do a partial review for the non-Xcode build stuff ) --Myles > On Jan 18, 2017, at 1:39 PM, Alex Christensen

Re: [webkit-dev] WebCore/platform standalone library

Windows must also stay a static library. I can volunteer the currently-completely-experimental-anyways Mac CMake build to have PAL as a shared library. It would be nice if people had more of a reason to keep it working. > On Jan 18, 2017, at 1:23 PM, Michael Catanzaro

Re: [webkit-dev] WebCore/platform standalone library

On Wed, 2017-01-18 at 12:17 -0800, Myles C. Maxfield wrote: > Static (At least for the Xcode projects. I imagine the cmake-based > projects could do whatever they want here). For GTK+ we really want static as well, we do not want a new shared library. So no difference here. Michael

Re: [webkit-dev] WebCore/platform standalone library

Alright - I’ve had a long and involved conversation with people who know things about Apple’s internal build infrastructure. The result of this conversation is: 1. Currently, the build infrastructure is configured in such a way as to not be compatible with a new folder in the top-level Source

Re: [webkit-dev] WebCore/platform standalone library

The ar utility isn’t a linker - it just collects object files. I don’t believe it has any concept of matching symbols up to exported symbols in external shared libraries (like JavaScriptCore for WTF). (But of course someone can correct me if I’m wrong.) —Myles > On Jan 14, 2017, at 1:38 PM,

Re: [webkit-dev] WebCore/platform standalone library

> On Jan 14, 2017, at 12:39 PM, Myles C. Maxfield wrote: > > However, a shared library would enforce layering naturally, whereas a static > library would need either an application to link to it and not to WebCore, > such as a unit test suite, or some out-of-band layering

Re: [webkit-dev] WebCore/platform standalone library

> On Jan 14, 2017, at 12:39 PM, Myles C. Maxfield wrote: > > Here’s a quick rundown of where we stand. Please correct me if any of this is > inaccurate. > > There are a few separate issues: > Path on disk of PAL folder: Sounds like everyone more-or-less agrees that >

Re: [webkit-dev] WebCore/platform standalone library

Here’s a quick rundown of where we stand. Please correct me if any of this is inaccurate. There are a few separate issues: Path on disk of PAL folder: Sounds like everyone more-or-less agrees that this should belong in Source/, not in Source/WebCore/. However, I believe this is currently

Re: [webkit-dev] WebCore/platform standalone library

13.01.2017, 19:26, "Michael Catanzaro" : > On Fri, 2017-01-13 at 11:39 -0200, Gustavo Sverzut Barbieri wrote: >>  On Thu, Jan 12, 2017 at 7:11 PM, Alex Christensen >>   wrote: >>  > If PAL were a shared library in a CMake build, then it wouldn’t >>  

Re: [webkit-dev] WebCore/platform standalone library

On Fri, 2017-01-13 at 11:39 -0200, Gustavo Sverzut Barbieri wrote: > On Thu, Jan 12, 2017 at 7:11 PM, Alex Christensen > wrote: > > If PAL were a shared library in a CMake build, then it wouldn’t > > build successfully if there were layering violations.  I think we > >

Re: [webkit-dev] WebCore/platform standalone library

On Thu, Jan 12, 2017 at 7:11 PM, Alex Christensen wrote: > If PAL were a shared library in a CMake build, then it wouldn’t build > successfully if there were layering violations. I think we should do > something like that to enforce good design, even if the Mac Xcode

Re: [webkit-dev] WebCore/platform standalone library

If PAL were a shared library in a CMake build, then it wouldn’t build successfully if there were layering violations. I think we should do something like that to enforce good design, even if the Mac Xcode projects treat it as a static library or even just a part of WebCore.

Re: [webkit-dev] WebCore/platform standalone library

webkit.org>] On Behalf Of Maciej Stachowiak >> Sent: Wednesday, January 11, 2017 2:05 PM >> To: Antti Koivisto <koivi...@iki.fi <mailto:koivi...@iki.fi>> >> Cc: Webkit Development List <webkit-dev@lists.webkit.org >> <mailto:webkit-dev@lists.webkit.or

Re: [webkit-dev] WebCore/platform standalone library

On Wed, 2017-01-11 at 23:30 +, Olmstead, Don wrote: > I had thought of PAL as a library that is internal to WebCore that > provides a clear porting layer. I would not expect anyone outside of > WebCore to be linking to it. So honestly, I don't think this is very realistic. Lots of stuff

Re: [webkit-dev] WebCore/platform standalone library

; Cc: Webkit Development List <webkit-dev@lists.webkit.org>; > mrobin...@igalia.com > Subject: Re: [webkit-dev] WebCore/platform standalone library > > > These both sound right to me. > > More generally, I would expect that over time, PAL would likely become

Re: [webkit-dev] WebCore/platform standalone library

Webkit Development List <webkit-dev@lists.webkit.org>; mrobin...@igalia.com Subject: Re: [webkit-dev] WebCore/platform standalone library These both sound right to me. More generally, I would expect that over time, PAL would likely become a peer project to WebCore instead of being inside it, much

Re: [webkit-dev] WebCore/platform standalone library

Really happy to see progress on this! On Tue, 2017-01-10 at 21:24 -0800, Myles C. Maxfield wrote: > First of all, this isn’t a new project; instead, it’s a new target > inside the WebCore project. The target creates a static library which > gets linked into WebCore, which means that the

Re: [webkit-dev] WebCore/platform standalone library

On Tue, 2017-01-10 at 21:28 -0800, Darin Adler wrote: > Given that WTF chose , what is the reasoning for PAL > choosing the all capital ? I kinda prefer myself, in order to parallel WTF. On the one hand, it almost doesn't matter, but on the other it's one more rule to have to memorize which

Re: [webkit-dev] WebCore/platform standalone library

These both sound right to me. More generally, I would expect that over time, PAL would likely become a peer project to WebCore instead of being inside it, much the same way WTF started inside JavaScriptCore and eventually moved outside it in the source tree. In the WTF case, it always had a

Re: [webkit-dev] WebCore/platform standalone library

Why is the PAL namespace inside the WebCore namespace? Couldn't it just be a top-level namespace (even if it currently happens to live in the WebCore project)? #include would be more consistent with existing headers than . antti On Wed, Jan 11, 2017 at 7:24 AM, Myles C. Maxfield

Re: [webkit-dev] WebCore/platform standalone library

On Jan 10, 2017, at 9:28 PM, Darin Adler wrote: >> On Jan 10, 2017, at 9:24 PM, Myles C. Maxfield wrote: >> >> We opted for WebCore to include files using “#include ” instead >> of just including Foo.h. > > Will this work without ForwardingHeaders on

Re: [webkit-dev] WebCore/platform standalone library

> On Jan 10, 2017, at 11:08 PM, Carlos Garcia Campos > wrote: > >> El mar, 10-01-2017 a las 21:24 -0800, Myles C. Maxfield escribió: >> After 18 months of no progress, Don Olmstead and I are getting the >> band back together! > > Great news. > >> We’ve uploaded a patch

Re: [webkit-dev] WebCore/platform standalone library

El mar, 10-01-2017 a las 21:24 -0800, Myles C. Maxfield escribió: > After 18 months of no progress, Don Olmstead and I are getting the > band back together! Great news. > We’ve uploaded a patch > to https://bugs.webkit.org/show_bug.cgi?id=143358 which incorporates > feedback from many different

Re: [webkit-dev] WebCore/platform standalone library

> On Jan 10, 2017, at 9:24 PM, Myles C. Maxfield wrote: > > We opted for WebCore to include files using “#include ” instead of > just including Foo.h. Will this work without ForwardingHeaders on macOS and iOS? Given that WTF chose , what is the reasoning for PAL choosing

Re: [webkit-dev] WebCore/platform standalone library

After 18 months of no progress, Don Olmstead and I are getting the band back together! We’ve uploaded a patch to https://bugs.webkit.org/show_bug.cgi?id=143358 which incorporates feedback from many different stakeholders (and as such, the

Re: [webkit-dev] WebCore/platform standalone library

On Mar 22, 2015, at 4:35 AM, Maciej Stachowiak m...@apple.com wrote: Web Abstraction Toolbox (it’s hard to tell the difference between wat and WTF sometimes…) +1 ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] WebCore/platform standalone library

I think we have a winner! If I suggest one.. how about WAFL? WebCore Abstraction Framework Layer It should sound sweet like waffle =) ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebCore/platform standalone library

We’ll have times when we need to decide what goes into this library, and what goes into WTF. So I like the ones that fit the sentence “Is this really WTF or is it just __?” LOL, ROFL and ROFLCOPTER work well for this. I would also suggest: Web Abstraction Toolbox (it’s hard to tell the

Re: [webkit-dev] WebCore/platform standalone library

Low-level Object Library. This sounds good to me. Something prefixed “NEW” could not be new forever. ;) If I suggest one.. how about WAFL? WebKit(or WebCore) Abstraction Framework Library(or Layer) It should sound sweet like waffle =) ChangSeok On Mar 21, 2015, at 3:26 AM, Simon Fraser

Re: [webkit-dev] WebCore/platform standalone library

Platform Interface and Testing Abstraction. - R. Niwa *P*latform *A*bstract *I*nterface ? Sound like delicious pie :) Gyuyoung On Sat, Mar 21, 2015 at 2:18 AM, Ryosuke Niwa rn...@webkit.org wrote: On Friday, March 20, 2015, Simon Fraser simon.fra...@apple.com wrote: On Mar 20, 2015, at

Re: [webkit-dev] WebCore/platform standalone library

Reusable Os Fitting Layer antti On Fri, Mar 20, 2015 at 11:26 AM, Simon Fraser simon.fra...@apple.com wrote: On Mar 20, 2015, at 11:03 AM, Edward O'Connor eocon...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of

Re: [webkit-dev] WebCore/platform standalone library

On Mar 20, 2015, at 11:03 AM, Edward O'Connor eocon...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a pro at this, but here are a few tries: Lower-level Object

Re: [webkit-dev] WebCore/platform standalone library

This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a pro at this, but here are a few tries: Lower-level Object Library. Algorithm Reuse Framework. New Framework for WebCore, New

Re: [webkit-dev] WebCore/platform standalone library

On Friday, March 20, 2015, Simon Fraser simon.fra...@apple.com wrote: On Mar 20, 2015, at 9:27 AM, Darin Adler da...@apple.com javascript:; wrote: On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com javascript:; wrote: This almost makes me want to suggest a jokey name for

Re: [webkit-dev] WebCore/platform standalone library

On Fri, Mar 20, 2015 at 9:56 AM, Simon Fraser simon.fra...@apple.com wrote: On Mar 20, 2015, at 9:27 AM, Darin Adler da...@apple.com wrote: On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the

Re: [webkit-dev] WebCore/platform standalone library

On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a pro at this, but here are a few tries: Lower-level Object Library.

Re: [webkit-dev] WebCore/platform standalone library

On Mar 20, 2015, at 9:27 AM, Darin Adler da...@apple.com wrote: New System Framework for WebCore This! -Filip ___ webkit-dev mailing list webkit-dev@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-dev

Re: [webkit-dev] WebCore/platform standalone library

On Mar 20, 2015, at 9:27 AM, Darin Adler da...@apple.com wrote: On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I am not a

Re: [webkit-dev] WebCore/platform standalone library

On Mar 20, 2015, at 11:40 AM, Antti Koivisto koivi...@iki.fi wrote: Reusable Os Fitting Layer …Containing Opensource Platform Types, Events, and Resources. -Jer antti On Fri, Mar 20, 2015 at 11:26 AM, Simon Fraser simon.fra...@apple.com mailto:simon.fra...@apple.com wrote:

Re: [webkit-dev] WebCore/platform standalone library

El mié, 18-03-2015 a las 21:43 -0700, Myles C. Maxfield escribió: Hello, all, I’d like to announce that I intend to create a standalone static library from the current contents of WebCore/platform over the coming months. This will involve creating a “Platform top-level directory and moving

Re: [webkit-dev] WebCore/platform standalone library

I think JavaScriptCore will need access to 'platform', too, to implement some ES6 features.  Saam On Thu, Mar 19, 2015 at 2:50 PM, Maciej Stachowiak m...@apple.com wrote: On Mar 19, 2015, at 1:47 PM, Benjamin Poulain benja...@webkit.org wrote: On 3/18/15 9:43 PM, Myles C. Maxfield

Re: [webkit-dev] WebCore/platform standalone library

On Mar 19, 2015, at 3:44 PM, saam barati saambara...@gmail.com wrote: I think JavaScriptCore will need access to 'platform', too, to implement some ES6 features. Anything needed for JavaScriptCore should go to WTF. Otherwise there is no point having a separation. - Maciej Saam

Re: [webkit-dev] WebCore/platform standalone library

On Mar 19, 2015, at 5:19 PM, Anders Carlsson ander...@apple.com wrote: On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com mailto:m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion

Re: [webkit-dev] WebCore/platform standalone library

On 3/19/15 2:49 PM, Maciej Stachowiak wrote: On Mar 19, 2015, at 1:47 PM, Benjamin Poulain benja...@webkit.org wrote: On 3/18/15 9:43 PM, Myles C. Maxfield wrote: Hello, all, I’d like to announce that I intend to create a standalone static library from the current contents of

Re: [webkit-dev] WebCore/platform standalone library

On Mar 19, 2015, at 2:49 PM, Maciej Stachowiak m...@apple.com wrote: This almost makes me want to suggest a jokey name for Platform. I can’t off the top of my head think of a good expansion of OMG, though. Or BBQ. I think putting platform code in a separate namespace would be a good first

Re: [webkit-dev] WebCore/platform standalone library

I do not intend on changing any interfaces or semantics. I only intend to change where code lives and library boundaries. There is no need to increase the scope of this project. Also, I do not intend on making up a comical name. --Myles On Mar 19, 2015, at 3:03 PM, Benjamin Poulain

Re: [webkit-dev] WebCore/platform standalone library

Sorry, I missed some of this thread before sending my reply. First, I'm going to try to get as far as I can by only moving over the non-layer-violating code. Therefore, for the interim, we will have both old and new directories. Then I will work on removing layering violations, one by one.

Re: [webkit-dev] WebCore/platform standalone library

On 3/18/15 9:43 PM, Myles C. Maxfield wrote: Hello, all, I’d like to announce that I intend to create a standalone static library from the current contents of WebCore/platform over the coming months. This will involve creating a “Platform top-level directory and moving source files into it,

Re: [webkit-dev] WebCore/platform standalone library

On Mar 19, 2015, at 1:47 PM, Benjamin Poulain benja...@webkit.org wrote: On 3/18/15 9:43 PM, Myles C. Maxfield wrote: Hello, all, I’d like to announce that I intend to create a standalone static library from the current contents of WebCore/platform over the coming months. This will

Re: [webkit-dev] WebCore/platform standalone library

On Wed, Mar 18, 2015 at 9:43 PM, Myles C. Maxfield mmaxfi...@apple.com wrote: I'd like to announce that I intend to create a standalone static library from the current contents of WebCore/platform over the coming months. This will involve creating a Platform top-level directory and moving