Re: [webkit-gtk] New API to add and retrieve (full) cookies via the CookieManager

2017-10-06 Thread Mario Sanchez Prada
On 05/10/17 17:06, Michael Catanzaro wrote: > On Thu, Oct 5, 2017 at 3:57 PM, Mario Sanchez Prada <ma...@webkit.org> wrote: >> More thoughts? > > The API proposal looks great. Thanks Michael. I almost finished the patches but needed to fork a bit my attention into a local

[webkit-gtk] New API to add and retrieve (full) cookies via the CookieManager

2017-10-05 Thread Mario Sanchez Prada
Hi all, I've been talking about this with Carlos and Michael during the Web Engines Hackfest, but I think it would be nice to send a mail here commenting on the new API I'd like to propose. But first of all, some higher-level background: At the moment, WebKitCookieManager does allow to do a few

Re: [webkit-gtk] FTL plans for 2.12

2016-02-02 Thread Mario Sanchez Prada
I think the plan you outlined makes a lot of sense, so +1 here too. Mario ___ webkit-gtk mailing list webkit-gtk@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-gtk

Re: [webkit-gtk] WebView avoiding propagation of some GtkWidget signals

2016-01-11 Thread Mario Sanchez Prada
On 08/01/16 19:47, philip.chime...@gmail.com wrote: > [...] > I think it makes a lot of sense, what you say above about always returning > FALSE specifically for mouse move events. With a click, I can see why the > WebView should swallow it; a click is always intended for one target. But > with a

Re: [webkit-gtk] WebView avoiding propagation of some GtkWidget signals

2016-01-08 Thread Mario Sanchez Prada
Hi Carlos, Thanks for the great feedback, as usual. See my comments below... On 08/01/16 07:02, Carlos Garcia Campos wrote: > [...] > Yes. Imagine the web view handles a key combination, if we propagate > the events always, if the parent window also handles that combination, > both things will

Re: [webkit-gtk] WebView avoiding propagation of some GtkWidget signals

2016-01-07 Thread Mario Sanchez Prada
On 07/01/16 07:19, Carlos Garcia Campos wrote: > [...] >> Carlos, Gustavo or anyone else... could you drop some light on this, >> please? > > The thing is that in the GTK+ events model, everything is synchronous, > so the event handlers return TRUE/FALSE dependening on whether the > event was

Re: [webkit-gtk] Wrong-drawing/rendering?

2015-10-26 Thread Mario Sanchez Prada
> > ___ > Noel Vellemans > BMS bvba > -Original Message- > From: Mario [mailto:mario...@gmail.com] On Behalf Of Mario Sanchez Prada > Sent: Friday, October 23, 2015 5:23 PM > To: Vellemans, Noel; webkit-gtk@lists.webkit.org > Subject: Re:

Re: [webkit-gtk] Wrong-drawing/rendering?

2015-10-23 Thread Mario Sanchez Prada
Hi Noel, I encountered a few issues recently related to rendering, but in my case those happened with 2.8.x/2.10.x series, couldn't see any with 2.4.9 so far. In any case, I think it would be helpful if you could submit the source file (or even better, a reduced test case) so that we can better

[webkit-gtk] Public API to allow setting AC mode on a permanent basis for a WebView

2015-10-23 Thread Mario Sanchez Prada
Hi, I recently spent some time debugging a few weird issues ([1],[2] and [3]) I was seeing in a local application and, after some digging, realized that some of them started happening in 2.8.x because of two main factors: * Before 2.8, PageClient's callbacks to enter/exit AC mode were no-ops

Re: [webkit-gtk] Crash on xLarge memory allocation with webkitgtk+ 2.8.3

2015-07-02 Thread Mario Sanchez Prada
On 24/06/15 21:58, Mario Sanchez Prada wrote: [...] Any reproducible test case, perhaps on a public Web page? Unfortunately, so far I can only reproduce this error by running an applications that embed WebKit and use it via GObject Introspection. I tried to write a simplified case I could

Re: [webkit-gtk] Crash on xLarge memory allocation with webkitgtk+ 2.8.3

2015-06-24 Thread Mario Sanchez Prada
On 24/06/15 19:00, z...@falconsigh.net wrote: On Wed, Jun 24, 2015, at 06:05 PM, Mario Sanchez Prada wrote: Hi all, I've recently upgraded the version of WebKitGTK+ in our platform from 2.6.4 to 2.8.3 and, quite surprisingly, it crashes now when used from some of the components that embed

[webkit-gtk] Crash on xLarge memory allocation with webkitgtk+ 2.8.3

2015-06-24 Thread Mario Sanchez Prada
Hi all, I've recently upgraded the version of WebKitGTK+ in our platform from 2.6.4 to 2.8.3 and, quite surprisingly, it crashes now when used from some of the components that embed WebKit, without any other change in the system other than that one. More specifically, this is an excerpt of the

Re: [webkit-gtk] testing text-caret-moved events

2014-05-06 Thread Mario Sanchez Prada
Hi Jarek, [...] Mario, later I thought more about it. length == 0 may have a specific meaning and may possibly be used to clear the selection. I have no idea whether atk_text_set_caret_offset clears the selection too. Ah! I think you are right here in what that length == 0 might be used

Re: [webkit-gtk] Exposing enable-web-security through WebKitSettings? (for test harnesses)

2014-03-18 Thread Mario Sanchez Prada
Hi Sven, Thanks for the feedback, you confirmed that this is not a so strange use case after all, so I filed the bug in bugzilla and attached a patch proposal for it, before I get busy with something else that makes me forget about it :): https://bugs.webkit.org/show_bug.cgi?id=130398 Thanks,

[webkit-gtk] Argument list too long error with old versions of CMake (2.8.10)

2014-03-13 Thread Mario Sanchez Prada
Hi, Today I hit the following error when trying to compile a fresh build using build-webkit -gtk (which now defaults to the CMake build system) in my Ubuntu 12.10 machine: Argument list too long ninja: build stopped: subcommand failed. The thing is that I would not spot that issue in

Re: [webkit-gtk] How to view file saved by webkit_web_view_save_to_file

2014-01-24 Thread Mario Sanchez Prada
Hi, WebCore used to recognize (and allow rendering) MHTML elements as files with mimetype message/rfc822, but that changed in May with the patch for bug 116442[2], which replaced the expected mimetype with application/x-mimearchive. However, you need to have a version of shared-mime-info that

Re: [webkit-gtk] Handling the run-file-chooser signal

2013-11-05 Thread Mario Sanchez Prada
Hi, -Original Message- [...] I've made some progress - it appears that initially I wasn't waiting long enough for the page to load and draw. I am now using a function that spins in the event loop for X seconds (which I want anyway to pace my interaction with the web servers), and

Re: [webkit-gtk] Handling the run-file-chooser signal

2013-11-05 Thread Mario Sanchez Prada
[...] Thank you! That pointed me in the right direction. Happy to help! :) Here is the solution for anyone interested. $view-signal_connect('run-file-chooser' = sub { my ($view, $FileChooserRequest) = @_; print Inside run-file-chooser handler\n;

Re: [webkit-gtk] Moving the caret with enable-caret-browsing set

2012-10-22 Thread Mario Sanchez Prada
On Sat, 2012-10-20 at 16:16 -0400, Nicholas Bishop wrote: With the enable-caret-browsing option set on a WebkitWebView, is it possible to programatically move the caret with respect to lines of text as they are appear on screen? For example, move to end of visual line rather than move to end

[webkit-gtk] [WK2] Implementing new API for spell checking in WebKit2GTK+

2012-06-29 Thread Mario Sanchez Prada
Hi, This is a brief mail to let you that I already started working in the spell checking new API for WebKit2GTK+, as it's part of the roadmap defined at [1]. As I'm leaving on holidays today and would like to leave things in shape so people can give feedback in the meanwhile if willing to, I've

Re: [webkit-gtk] File chooser signal backported to WebKit1

2012-05-23 Thread Mario Sanchez Prada
Hi Daniel, On Wed, 2012-05-23 at 11:43 -0600, Daniel Drake wrote: [...] Thanks so much for helping out here! You're welcome. I've filed https://bugs.webkit.org/show_bug.cgi?id=87283 with your work rolled into my initial backport. Adding the unit tests looks a bit tricky indeed. I'm also a

Re: [webkit-gtk] webkitgtk-1.8.x and Java/Flash plugins

2012-05-05 Thread Mario Sanchez Prada
On Wed, 2012-05-02 at 15:57 -0600, Daniel Drake wrote: [...] This isn't working, unfortantely :( I removed libflashplayer.so from the normal load paths, and then I passed it to nspluginwrapper to be natively wrapped. I also removed all other plugins just to be sure. Then, it works in the

Re: [webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation

2012-04-10 Thread Mario Sanchez Prada
[sorry for the delay in the answer, being on holidays since wednesday] On Thu, 2012-04-05 at 11:27 +1200, Gavin Lambert wrote: Quoth Carlos Garcia Campos: Just because it makes the API simpler, using a single signal in WebKitWebView to handle policy decisions. The geolocation API is quite

Re: [webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation

2012-04-04 Thread Mario Sanchez Prada
On Tue, 2012-04-03 at 08:31 -0700, Martin Robinson wrote: [...] It is true that a 'download' action exists for a new decision type that it doesn't make sense for. Consider that it already only ever makes sense for WebkitResponsePolicyDecisions. Take a look at the documentation in

Re: [webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation

2012-04-04 Thread Mario Sanchez Prada
On Tue, 2012-04-03 at 17:47 +0200, Carlos Garcia Campos wrote: [...] Here is where you lose me. It is possible that geolocation requests do not fit into the policy decision framework, but not because of this issue. I say this because the issue already existed with

Re: [webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation

2012-04-03 Thread Mario Sanchez Prada
On Mon, 2012-04-02 at 15:42 -0700, Martin Robinson wrote: [...] It would be great to hear more opinions then. I like the approach in option 1, Just a nitpick: what you're describing below in this mail is basically Option 2, as you're talking about defining a PolicyDecisionListener abstract

Re: [webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation

2012-04-03 Thread Mario Sanchez Prada
On Tue, 2012-04-03 at 08:59 +0200, Carlos Garcia Campos wrote: El lun, 02-04-2012 a las 15:42 -0700, Martin Robinson escribió: I like the approach in option 1, but I think that we can scrap the GObject interface with an abstract C++ class in the private data portion of the

[webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation

2012-03-30 Thread Mario Sanchez Prada
Hi all, A couple of days ago I started working in the implementation of geolocation support for WebKit2GTK+ (see [1]), and came to the conclusion that the Policy decision we have already in place could be useful for implementing the decision making mechanism that we need here. Such a mechanism

Re: [webkit-gtk] WK2: Adapting the Policy Decision Framework for Geolocation

2012-03-30 Thread Mario Sanchez Prada
Just realized I messed some things up here. Now clarifying... On Fri, 2012-03-30 at 13:13 +0200, Mario Sanchez Prada wrote: [...] I've attached some quick diagrams I made with Dia to better explain what's in my head at this moment. Forget about the geoclue-related stuff in the diagrams. Those

Re: [webkit-gtk] WK2: Adapting the Policy Decision Framework

2012-03-30 Thread Mario Sanchez Prada
On Fri, 2012-03-30 at 16:10 +0200, Mario Sanchez Prada wrote: [...] For the time being, I will keep working having Option 1 in mind. I've advanced quite a lot and have to say it's even starting to make sense to me. Hope I'm not assuming too much... :) Attaching a rough patch implementing

Re: [webkit-gtk] Implement runOpenPanel in WebKit2GTK+

2012-02-14 Thread Mario Sanchez Prada
On Tue, 2012-02-14 at 08:37 -0800, Martin Robinson wrote: On Tue, Feb 14, 2012 at 1:14 AM, Mario Sanchez Prada msanc...@igalia.com wrote: I had the same doubt yesterday, but Carlos convinced me with the rationale we explained above. However, if we agree consistency is important I think I

Re: [webkit-gtk] Implement runOpenPanel in WebKit2GTK+

2012-02-14 Thread Mario Sanchez Prada
On Tue, 2012-02-14 at 19:10 +0100, Simon Schampijer wrote: Hi Mario others, thanks a lot for your work on this track! This is the missing piece for the path I took. I think it will work very well to pass the WebKitFileChooserRequest request with the signal and then the app can handle

Re: [webkit-gtk] Implement runOpenPanel in WebKit2GTK+

2012-02-13 Thread Mario Sanchez Prada
On Mon, 2012-02-13 at 11:12 -0200, Gustavo Noronha Silva wrote: +1 on Carlos' API suggestions Thank you for all the provided feedback (including Martin's here as well). I have already incorporated all of these suggestions in my local branch and have filed a new bug to properly tracking work done

[webkit-gtk] Implement runOpenPanel in WebKit2GTK+

2012-02-10 Thread Mario Sanchez Prada
not a final patch, but more kind of a draft :-) Mario From 4a1f7c1525dac9cb4f81c1c198c53a913830d98f Mon Sep 17 00:00:00 2001 From: Mario Sanchez Prada msanc...@igalia.com Date: Fri, 10 Feb 2012 12:13:59 +0100 Subject: [PATCH] Implement runOpenPanel in WebKit2GTK+ --- Source/WebKit2/GNUmakefile.am

Re: [webkit-gtk] Custom Filechooser dialog

2012-02-10 Thread Mario Sanchez Prada
Hi, On Fri, 2012-02-10 at 13:03 +0100, Simon Schampijer wrote: [...] Ok, I did an initial patch (attached) to pipe an upload-requested signal out, the return value is a boolean to indicate whether the application handles the upload or not. We have to get back the information from the

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Mario Sanchez Prada
On Thu, 2012-02-02 at 19:54 +0100, Xan wrote: On Thu, Feb 2, 2012 at 6:36 PM, Carlos Garcia Campos cgar...@igalia.com wrote: Does not look like the most elegant API in the world to me. Agree, problem is, what is the effective zoom initially when both scale factor are 1? Yes. I guess

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Mario Sanchez Prada
On Tue, 2012-02-07 at 12:29 +0100, Carlos Garcia Campos wrote: [...] That use case is typically implemented changing the font size, instead of scaling the text. Ok then. I knew I was missing something... :) Mario ___ webkit-gtk mailing list

Re: [webkit-gtk] WebKitWebHistoryItem

2010-05-31 Thread Mario Sanchez Prada
On Wed, 2010-05-26 at 16:51 +0530, EBerry-EdBook wrote: hi please someone tells me how to implement history in my browser using WebKitWebHistoryItem. I'm not an expert on this matter but I guess you could find perhaps some inspiration by taking a look in the code of the Epiphany browser [1],

[webkit-gtk] Root (accessible) element in WebKitGtk+

2010-04-29 Thread Mario Sanchez Prada
Hi, I've recently started to look at a11y issues in WebKitGtk (nothing too impressive, just taking a look by the moment :-)), and I found the implementation a bit strange, and not sure whethers there's a reason for that I'm missing (most likely, I'd say): //