Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-08 Thread Gustavo Noronha Silva
On Tue, 2012-02-07 at 09:45 -0800, Martin Robinson wrote: On Tue, Feb 7, 2012 at 7:50 AM, Carlos Garcia Campos cgar...@igalia.com wrote: I think text zoom is to scale the text but not the page contents, that's how all webkitgtk embedders I've seen use it. What I meant here is that

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Mario Sanchez Prada
On Thu, 2012-02-02 at 19:54 +0100, Xan wrote: On Thu, Feb 2, 2012 at 6:36 PM, Carlos Garcia Campos cgar...@igalia.com wrote: Does not look like the most elegant API in the world to me. Agree, problem is, what is the effective zoom initially when both scale factor are 1? Yes. I guess

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Carlos Garcia Campos
El mar, 07-02-2012 a las 12:10 +0100, Mario Sanchez Prada escribió: On Thu, 2012-02-02 at 19:54 +0100, Xan wrote: On Thu, Feb 2, 2012 at 6:36 PM, Carlos Garcia Campos cgar...@igalia.com wrote: Does not look like the most elegant API in the world to me. Agree, problem is, what is the

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Mario Sanchez Prada
On Tue, 2012-02-07 at 12:29 +0100, Carlos Garcia Campos wrote: [...] That use case is typically implemented changing the font size, instead of scaling the text. Ok then. I knew I was missing something... :) Mario ___ webkit-gtk mailing list

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Carlos Garcia Campos
El mar, 07-02-2012 a las 06:47 -0800, Martin Robinson escribió: On Tue, Feb 7, 2012 at 3:29 AM, Carlos Garcia Campos cgar...@igalia.com wrote: That use case is typically implemented changing the font size, instead of scaling the text. Is this just in WebKitGTK+ embedders? I think text

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Martin Robinson
On Tue, Feb 7, 2012 at 7:50 AM, Carlos Garcia Campos cgar...@igalia.com wrote: I think text zoom is to scale the text but not the page contents, that's how all webkitgtk embedders I've seen use it. What I meant here is that changing the default font size is not a great way to zoom the page. I

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-07 Thread Gavin Lambert
Quoth Carlos Garcia Campos wrote: That use case is typically implemented changing the font size, instead of scaling the text. Does that work if the page designer has specified font sizes in an absolute unit such as px rather than a relative one such as em? Without completely overriding the

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-05 Thread Carlos Garcia Campos
El vie, 03-02-2012 a las 12:29 -0200, Gustavo Noronha Silva escribió: I also don't remember any use case mentioned in the other thread other than people saying some client had requested it. Perhaps my memory is failing me, but if there are valid use cases it would be useful to hear them.

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-02 Thread Xan
On Thu, Feb 2, 2012 at 4:57 PM, Carlos Garcia Campos cgar...@igalia.com wrote: Unfortunately I think that still would count as an API break. Changing how the API behaves is an API break, even if your application still compiles. So it's not as safe as you make it sound, IMHO. Considering that

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-02 Thread Xan
On Thu, Feb 2, 2012 at 5:25 PM, Carlos Garcia Campos cgar...@igalia.com wrote: Since setting one resets the other, the one returning something different than 1 is the effective one. If both return 1, no scale factor is applied so the assumption is still valid. Does not look like the most

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-02 Thread Carlos Garcia Campos
El jue, 02-02-2012 a las 17:34 +0100, Xan escribió: On Thu, Feb 2, 2012 at 5:25 PM, Carlos Garcia Campos cgar...@igalia.com wrote: Since setting one resets the other, the one returning something different than 1 is the effective one. If both return 1, no scale factor is applied so the

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-02 Thread Gavin Lambert
Quoth Carlos Garcia Campos: I still haven't heard of any use case where you want to set both scales at the same time, all other ports don't allow it because it produces unexpected odd results, so I still think we shouldn't support it. The only use case which occurs to me is for someone who

Re: [webkit-gtk] WebKit2 zoom API (II)

2012-02-02 Thread Carlos Garcia Campos
El vie, 03-02-2012 a las 11:09 +1300, Gavin Lambert escribió: Quoth Carlos Garcia Campos: I still haven't heard of any use case where you want to set both scales at the same time, all other ports don't allow it because it produces unexpected odd results, so I still think we shouldn't