Re: [Wengophone-devel] [PATCH 2 of 6] [mq]: owutil_util_CMakeLists.txt.patch

2008-03-11 Thread Darshaka Pathirana
On 27.02.2008 16:25, Vadim Lebedev wrote:
 Darshaka Pathirana wrote:
 # HG changeset patch
 # User Darshaka Pathirana [EMAIL PROTECTED]
 # Date 1204047217 -3600
 # Node ID c852f7f978912b812ab72ff62a731c7418a8bd02
 # Parent  e146fc8a386718fa7c4c7474258ca6df52aa89ce
 [mq]: owutil_util_CMakeLists.txt.patch

 diff -r e146fc8a3867 -r c852f7f97891 libs/owutil/util/CMakeLists.txt
 --- a/libs/owutil/util/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/libs/owutil/util/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -4,6 +4,13 @@
  owcutil
  boost
  )
 +
 +if (WIN32)
 +ow_add_private_definitions(
 +-DOWUTIL_DLL
 +-DBUILD_OWUTIL_DLL
 +)
 +endif (WIN32)
  
  ow_add_sources(
  src/Base64.cpp
 diff -r e146fc8a3867 -r c852f7f97891 libs/webcam/CMakeLists.txt
 --- a/libs/webcam/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/libs/webcam/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -17,6 +17,13 @@
  pixertool
  owthread
  )
 +
 +if (WIN32)
 +ow_add_private_definitions(
 +-DWEBCAM_DLL
 +-DBUILD_WEBCAM_DLL
 +)
 +endif (WIN32)
  
  ow_add_public_include_dirs(
  ${CMAKE_CURRENT_SOURCE_DIR}/include
 diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi-util/CMakeLists.txt
 --- a/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -9,6 +9,10 @@
  )
  
  if (WIN32)
 +ow_add_private_definitions(
 +-DPHAPIUTIL_DLL
 +-DBUILD_PHAPIUTIL_DLL
 +)
  ow_add_public_include_dirs(
  ${CMAKE_CURRENT_SOURCE_DIR}/include/phapi-util/msvc
  )
 diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi/CMakeLists.txt
 --- a/wifo/phapi/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/wifo/phapi/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -56,6 +56,11 @@
  -DPH_FORCE_16KHZ=1
  -DUSE_FLV1_OVER_H261=1
  )
 +if (WIN32)
 +ow_add_private_definitions(
 +-DBUILD_PHAPI_DLL
 +)
 +endif (WIN32)
  
  if (PHAPI_CODEC_ILBC_SUPPORT)
  ow_add_private_definitions(
 ___
 Wengophone-devel mailing list
 Wengophone-devel@lists.openwengo.com
 http://dev.openwengo.com/mailman/listinfo/wengophone-devel


   
 Darshaka,
 
 Are you sure that you  REALLY need this stuff?  Because it compiles and
 works fine without it (wits VS2003)
 If you're positive can sombedy please confirm that this does not break
 VS2003 builds?

Just for reference: This patch does not break the nmake build.
Works for nmake (VS2003) and out of VS2005.

Greetings,
 - Darsha


___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel


[Wengophone-devel] [PATCH 2 of 6] [mq]: owutil_util_CMakeLists.txt.patch

2008-02-27 Thread Darshaka Pathirana
# HG changeset patch
# User Darshaka Pathirana [EMAIL PROTECTED]
# Date 1204047217 -3600
# Node ID c852f7f978912b812ab72ff62a731c7418a8bd02
# Parent  e146fc8a386718fa7c4c7474258ca6df52aa89ce
[mq]: owutil_util_CMakeLists.txt.patch

diff -r e146fc8a3867 -r c852f7f97891 libs/owutil/util/CMakeLists.txt
--- a/libs/owutil/util/CMakeLists.txt   Tue Feb 26 18:05:34 2008 +0100
+++ b/libs/owutil/util/CMakeLists.txt   Tue Feb 26 18:33:37 2008 +0100
@@ -4,6 +4,13 @@
owcutil
boost
 )
+
+if (WIN32)
+ow_add_private_definitions(
+   -DOWUTIL_DLL
+   -DBUILD_OWUTIL_DLL
+)
+endif (WIN32)
 
 ow_add_sources(
src/Base64.cpp
diff -r e146fc8a3867 -r c852f7f97891 libs/webcam/CMakeLists.txt
--- a/libs/webcam/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
+++ b/libs/webcam/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
@@ -17,6 +17,13 @@
pixertool
owthread
 )
+
+if (WIN32)
+ow_add_private_definitions(
+   -DWEBCAM_DLL
+   -DBUILD_WEBCAM_DLL
+)
+endif (WIN32)
 
 ow_add_public_include_dirs(
${CMAKE_CURRENT_SOURCE_DIR}/include
diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi-util/CMakeLists.txt
--- a/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
+++ b/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
@@ -9,6 +9,10 @@
 )
 
 if (WIN32)
+   ow_add_private_definitions(
+   -DPHAPIUTIL_DLL
+   -DBUILD_PHAPIUTIL_DLL
+   )
ow_add_public_include_dirs(
${CMAKE_CURRENT_SOURCE_DIR}/include/phapi-util/msvc
)
diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi/CMakeLists.txt
--- a/wifo/phapi/CMakeLists.txt Tue Feb 26 18:05:34 2008 +0100
+++ b/wifo/phapi/CMakeLists.txt Tue Feb 26 18:33:37 2008 +0100
@@ -56,6 +56,11 @@
-DPH_FORCE_16KHZ=1
-DUSE_FLV1_OVER_H261=1
 )
+if (WIN32)
+   ow_add_private_definitions(
+   -DBUILD_PHAPI_DLL
+   )
+endif (WIN32)
 
 if (PHAPI_CODEC_ILBC_SUPPORT)
ow_add_private_definitions(
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel


Re: [Wengophone-devel] [PATCH 2 of 6] [mq]: owutil_util_CMakeLists.txt.patch

2008-02-27 Thread Vadim Lebedev

Darshaka Pathirana wrote:

# HG changeset patch
# User Darshaka Pathirana [EMAIL PROTECTED]
# Date 1204047217 -3600
# Node ID c852f7f978912b812ab72ff62a731c7418a8bd02
# Parent  e146fc8a386718fa7c4c7474258ca6df52aa89ce
[mq]: owutil_util_CMakeLists.txt.patch

diff -r e146fc8a3867 -r c852f7f97891 libs/owutil/util/CMakeLists.txt
--- a/libs/owutil/util/CMakeLists.txt   Tue Feb 26 18:05:34 2008 +0100
+++ b/libs/owutil/util/CMakeLists.txt   Tue Feb 26 18:33:37 2008 +0100
@@ -4,6 +4,13 @@
owcutil
boost
 )
+
+if (WIN32)
+ow_add_private_definitions(
+   -DOWUTIL_DLL
+   -DBUILD_OWUTIL_DLL
+)
+endif (WIN32)
 
 ow_add_sources(

src/Base64.cpp
diff -r e146fc8a3867 -r c852f7f97891 libs/webcam/CMakeLists.txt
--- a/libs/webcam/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
+++ b/libs/webcam/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
@@ -17,6 +17,13 @@
pixertool
owthread
 )
+
+if (WIN32)
+ow_add_private_definitions(
+   -DWEBCAM_DLL
+   -DBUILD_WEBCAM_DLL
+)
+endif (WIN32)
 
 ow_add_public_include_dirs(

${CMAKE_CURRENT_SOURCE_DIR}/include
diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi-util/CMakeLists.txt
--- a/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
+++ b/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
@@ -9,6 +9,10 @@
 )
 
 if (WIN32)

+   ow_add_private_definitions(
+   -DPHAPIUTIL_DLL
+   -DBUILD_PHAPIUTIL_DLL
+   )
ow_add_public_include_dirs(
${CMAKE_CURRENT_SOURCE_DIR}/include/phapi-util/msvc
)
diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi/CMakeLists.txt
--- a/wifo/phapi/CMakeLists.txt Tue Feb 26 18:05:34 2008 +0100
+++ b/wifo/phapi/CMakeLists.txt Tue Feb 26 18:33:37 2008 +0100
@@ -56,6 +56,11 @@
-DPH_FORCE_16KHZ=1
-DUSE_FLV1_OVER_H261=1
 )
+if (WIN32)
+   ow_add_private_definitions(
+   -DBUILD_PHAPI_DLL
+   )
+endif (WIN32)
 
 if (PHAPI_CODEC_ILBC_SUPPORT)

ow_add_private_definitions(
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel


  

Darshaka,

Are you sure that you  REALLY need this stuff?  Because it compiles and 
works fine without it (wits VS2003)
If you're positive can sombedy please confirm that this does not break 
VS2003 builds?



Thanks
Vadim
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel


Re: [Wengophone-devel] [PATCH 2 of 6] [mq]: owutil_util_CMakeLists.txt.patch

2008-02-27 Thread Darshaka Pathirana
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 27.02.2008 16:25, Vadim Lebedev wrote:
 Darshaka Pathirana wrote:
 # HG changeset patch
 # User Darshaka Pathirana [EMAIL PROTECTED]
 # Date 1204047217 -3600
 # Node ID c852f7f978912b812ab72ff62a731c7418a8bd02
 # Parent  e146fc8a386718fa7c4c7474258ca6df52aa89ce
 [mq]: owutil_util_CMakeLists.txt.patch

 diff -r e146fc8a3867 -r c852f7f97891 libs/owutil/util/CMakeLists.txt
 --- a/libs/owutil/util/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/libs/owutil/util/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -4,6 +4,13 @@
  owcutil
  boost
  )
 +
 +if (WIN32)
 +ow_add_private_definitions(
 +-DOWUTIL_DLL
 +-DBUILD_OWUTIL_DLL
 +)
 +endif (WIN32)
  
  ow_add_sources(
  src/Base64.cpp
 diff -r e146fc8a3867 -r c852f7f97891 libs/webcam/CMakeLists.txt
 --- a/libs/webcam/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/libs/webcam/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -17,6 +17,13 @@
  pixertool
  owthread
  )
 +
 +if (WIN32)
 +ow_add_private_definitions(
 +-DWEBCAM_DLL
 +-DBUILD_WEBCAM_DLL
 +)
 +endif (WIN32)
  
  ow_add_public_include_dirs(
  ${CMAKE_CURRENT_SOURCE_DIR}/include
 diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi-util/CMakeLists.txt
 --- a/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/wifo/phapi-util/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -9,6 +9,10 @@
  )
  
  if (WIN32)
 +ow_add_private_definitions(
 +-DPHAPIUTIL_DLL
 +-DBUILD_PHAPIUTIL_DLL
 +)
  ow_add_public_include_dirs(
  ${CMAKE_CURRENT_SOURCE_DIR}/include/phapi-util/msvc
  )
 diff -r e146fc8a3867 -r c852f7f97891 wifo/phapi/CMakeLists.txt
 --- a/wifo/phapi/CMakeLists.txtTue Feb 26 18:05:34 2008 +0100
 +++ b/wifo/phapi/CMakeLists.txtTue Feb 26 18:33:37 2008 +0100
 @@ -56,6 +56,11 @@
  -DPH_FORCE_16KHZ=1
  -DUSE_FLV1_OVER_H261=1
  )
 +if (WIN32)
 +ow_add_private_definitions(
 +-DBUILD_PHAPI_DLL
 +)
 +endif (WIN32)
  
  if (PHAPI_CODEC_ILBC_SUPPORT)
  ow_add_private_definitions(
 ___
 Wengophone-devel mailing list
 Wengophone-devel@lists.openwengo.com
 http://dev.openwengo.com/mailman/listinfo/wengophone-devel


   
 
 Are you sure that you  REALLY need this stuff?  Because it compiles and
 works fine without it (wits VS2003)
 If you're positive can sombedy please confirm that this does not break
 VS2003 builds?

*I* really needed these defininitions. I had to play around a long
time to find these settings to get VC to compile wengophone. Maybe
we can ask Chris Botor (who also tried to build wengophone with
VS2005 one month ago).

Chris, are you still in the list and had any success on building
wengophone with VS2005? Can you provide any info on this issue?

I am sorry that I can not provide any infos on VS2003. Let's see if
somebody else can do that.

Greetings,
 - Darsha
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHxaNPzSfkDjyvKakRAq4aAJ9FQ9ptC87CfIQvzOGjiQNkpxbqcwCg2Wfk
wyzckTdjtQd7Jc8Qi1DsJeQ=
=KjlC
-END PGP SIGNATURE-
___
Wengophone-devel mailing list
Wengophone-devel@lists.openwengo.com
http://dev.openwengo.com/mailman/listinfo/wengophone-devel