[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[J Tyne]

Update of bug #24456 (project wesnoth):

  Status:   Need Info => Invalid
 Open/Closed:Open => Closed 

___

Follow-up Comment #18:

Guess I should clarify that my earlier comment was directed at someone who had
nothing constructive to contribute to the discussion. I hope it does not
discourage someone with something to contribute.

In any event, it's been over a week, so I'll close this bug report as working
correctly. (The one month time frame was really because of the high chance
that I would forget to come back.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[J Tyne]

Follow-up Comment #17, bug #24456 (project wesnoth):

When I made the commit *four years ago*, I knew how it behaved. After spending
over two years without looking at Wesnoth code, I've forgotten details. So,
yes, it was a guess based upon a quick look at the commit. If that's not good
enough for you, you can just go away.

I'd ask about the problem that was found, but I have no interest in continuing
a discussion with you.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[J Tyne]

Follow-up Comment #12, bug #24456 (project wesnoth):

That "mostlikeley" phrasing makes me think you are guessing about what
happens. I can do that to: the change to the c++ code most likely affects only
those specials without filters.

Guessing games are not productive. It is not hard to play test this and see
what is shown for your favorite weapon specials. Please either come up with a
concrete example or read the code instead of guessing what it does.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Daniel]

Follow-up Comment #11, bug #24456 (project wesnoth):

Yes but the change to the c++ code mostlikeley effects all those specials not
just charge

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[J Tyne]

Follow-up Comment #10, bug #24456 (project wesnoth):

Charge doesn't have a filter.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Daniel]

Follow-up Comment #9, bug #24456 (project wesnoth):

We shodul at least have the right side panel show the attack damage in green
like it does when the unit is under leadershp to indicate that this is a
'buffed' damage, this is even more important when the special has for example
a filter so that the buff might no longer apply when te unit moves to its
tagret.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Wedge009]

Follow-up Comment #8, bug #24456 (project wesnoth):

Thanks for the clarification. This makes sense to me and agree the change
should remain.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[J Tyne]

Update of bug #24456 (project wesnoth):

  Status:None => Need Info  
 Assigned to:None => jamit  

___

Follow-up Comment #7:

I believe this is about a commit I did for 1.11.1
(1c71d69f5b6515954abc6400791e9867e946403f).

If it's your turn, the damage of your units includes charge, because that's
when charge applies. If it's not your turn, the damage of your units will not
include charge. Similarly for others' units: they include charge on their turn
and do not include charge when it's not their turn. That is not logical?

This is working as intended. If you disagree with the intent, please respond.
Otherwise, I (or someone) will close this eventually.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Amok]

Follow-up Comment #6, bug #24456 (project wesnoth):

Damage should not always include charge, it would be illogical.

I examined my replay too and also damage was normal 8.

So, _sometimes_ dmg was showed wrong. I could remeber 2 times.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Wedge009]

Follow-up Comment #5, bug #24456 (project wesnoth):

Yes, I did.

I cannot recall for certain whether the damage indicator always includes
charge or not. Regardless, the behaviour is consistent with my current build
of the 1.12 branch.

I also examined your replay previously and see no cause for concern.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Amok]

Follow-up Comment #4, bug #24456 (project wesnoth):

Good math, but you carefully examine screenshot, did you?

Mouse cursor was OVER horse (without any target), so game engine should show
damage without charge, right?

Open replay at least, forward to night and point cursor by yourself.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Wedge009]

Follow-up Comment #3, bug #24456 (project wesnoth):

I don't think this is a bug. It looks like you're not taking into account that
a horseman uses charge, plus it has the strong trait.

Base damage of 9
Strong trait adds 1 to base
Charge damage multiplier is 2
Time of day multiplier is 0.75 for lawful units at night

So standard attack = (9 + 1) x 2 x 0.75 = 15

Additionally, a defending unit may be resistant to piercing attacks,
particularly skeletal undead. If a unit has 50% resistance to piercing attacks
we would get:

15 x 0.5 = 8 (rounded to integer value)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[Amok]

Follow-up Comment #2, bug #24456 (project wesnoth):

I found replay:
http://replays.wesnoth.org/1.12/20160107/5p__Auction-X_Turn_22_(55078).bz2

It was standard Auction-X. Btw, actual dmg of this horse was 8.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[ancestral]

Follow-up Comment #1, bug #24456 (project wesnoth):

What scenario or map were you using?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #24456] Wrong damage numbers in unit's description.

[_]

URL:
  

 Summary: Wrong damage numbers in unit's description.
 Project: Battle for Wesnoth
Submitted by: amok
Submitted on: Чт 25 фев 2016 04:40:11
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.12.5
Operating System: Win7Pro x64

___

Details:

Subj. No replay.



___

File Attachments:


---
Date: Чт 25 фев 2016 04:40:11  Name: wrong_dmg.png  Size: 916kB   By:
amok



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs