-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Gisle Vanem wrote:
> I've been porting Wget to MSDOS using the djgpp environment.
> The task was rather simple; adding a new directory ./msdos with
> a config.h and Makefile.dj. I intend to support other DOS-compilers
> later. 
> Please take a look at the attached patch and ./msdos files. Would there
> be any interest in adding this?

These look decent to me, Gisle; I've added a bug report to Savannah to
mark the task of merging this in. I will need to wait on these changes,
though, until the FSF has your copyright assignment on file.

Huh, there were a couple constructs in there that I had been thinking
were C99; the user of a final comma after array element initializers,
and the preprocessing "defined()" operator. Both of those seem to be in
my draft copy of C89, though, so I guess I'm wrong.

I know final commas in /enum/ declarations are a new addition, maybe
that's what confused me...

The addition of yet more #ifdefs bug me a small amount; I'm hoping at
some point to convert the code to comply with GNU guidelines that such
things be avoided; but it's really not going to add more work at that
point if I let these in, and in the meantime it's consistent with the
rest of the code, so I won't ask you to change that.

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer...
http://micah.cowan.name/

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFG1HpA7M8hyUobTrERCMUoAJ9SlkyfC0nxxj/i1UwgKOSPbnYZWwCgkotz
EYLQwMxwEf1LAj8CzFMOk8A=
=w4vD
-----END PGP SIGNATURE-----

Reply via email to