Re: fnmatch and non-ASCII characters in .listing

[Micah Cowan]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hrvoje Niksic wrote:
 A Wget user showed me an example of Wget misbehaving.

Hrvoje, do you know if this is a regression over 1.10.2? I'm guessing
the use of fnmatch() being locale-dependant isn't; what about the rest?

And; do you think this is important enough to put in for 1.11, possibly
delaying its release and risking further bugs; or should it wait a
couple weeks for 1.11.x or 1.12?

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer...
http://micah.cowan.name/
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHUd1M7M8hyUobTrERAsgsAJ9JCtRg6xMD8yOe2+m+6NpBGDAFsgCdEMcX
iC10hTUvIZ9oA3nxvBgW/CQ=
=gD1v
-END PGP SIGNATURE-

Re: fnmatch and non-ASCII characters in .listing

[Hrvoje Niksic]

Micah Cowan [EMAIL PROTECTED] writes:

 Hrvoje Niksic wrote:
 A Wget user showed me an example of Wget misbehaving.

 Hrvoje, do you know if this is a regression over 1.10.2?

I don't think so, but it's probably a regression over 1.9.x.  In 1.10
Wget started to set up the locale by calling setlocale(LC_ALL...), and
it's biting us in places like this.

 I'm guessing the use of fnmatch() being locale-dependant isn't; what
 about the rest?

The error message could be a regression, but I didn't actually check.
The faulty logic that uses fnmatch even when strcmp would sufffice
looks like it's been inherited since very early versions.

 And; do you think this is important enough to put in for 1.11,
 possibly delaying its release and risking further bugs; or should it
 wait a couple weeks for 1.11.x or 1.12?

If 1.11 is frozen, this is not important enough to break the freeze,
because it only happens in very specific circumstances.  It looks like
material for a 1.11.1.