Re: Bug in Windows binary?

[Gisle Vanem]

Jens Rsner [EMAIL PROTECTED] said:

 I downloaded
 wget 1.9 beta 2003/09/29 from Heiko
 http://xoomer.virgilio.it/hherold/
...
 wget -d http://www.google.com
 DEBUG output created by Wget 1.9-beta on Windows.

 set_sleep_mode(): mode 0x8001, rc 0x8000

 I disabled my wgetrc as well and the output was exactly the same.

 I then tested
 wget 1.9 beta 2003/09/18 (earlier build!)
 from the same place and it works smoothly.

 Can anyone reproduce this bug?

Yes, but the MSVC version crashed on my machine.  But I've found
the cause caused by my recent change :(

A simple case of wrong calling-convention:

--- mswindows.c.org Mon Sep 29 11:46:06 2003
+++ mswindows.c Sun Oct 05 17:34:48 2003
@@ -306,7 +306,7 @@
 DWORD set_sleep_mode (DWORD mode)
 {
   HMODULE mod = LoadLibrary (kernel32.dll);
-  DWORD (*_SetThreadExecutionState) (DWORD) = NULL;
+  DWORD (WINAPI *_SetThreadExecutionState) (DWORD) = NULL;
   DWORD rc = (DWORD)-1;

I assume Heiko didn't notice it because he doesn't have that function
in his kernel32.dll. Heiko and Hrvoje, will you correct this ASAP?

--gv

Re: Bug in Windows binary?

[Hrvoje Niksic]

Gisle Vanem [EMAIL PROTECTED] writes:

 --- mswindows.c.org Mon Sep 29 11:46:06 2003
 +++ mswindows.c Sun Oct 05 17:34:48 2003
 @@ -306,7 +306,7 @@
  DWORD set_sleep_mode (DWORD mode)
  {
HMODULE mod = LoadLibrary (kernel32.dll);
 -  DWORD (*_SetThreadExecutionState) (DWORD) = NULL;
 +  DWORD (WINAPI *_SetThreadExecutionState) (DWORD) = NULL;
DWORD rc = (DWORD)-1;

 I assume Heiko didn't notice it because he doesn't have that
 function in his kernel32.dll. Heiko and Hrvoje, will you correct
 this ASAP?

I've now applied the patch, thanks.  I use the following ChangeLog
entry:

2003-10-05  Gisle Vanem  [EMAIL PROTECTED]

* mswindows.c (set_sleep_mode): Fix type of
_SetThreadExecutionState.

subscribe wget

[Josh Brooks]