Re: Patch for Windows Build

2007-02-11 Thread Hrvoje Niksic
Applied, thanks.  Sorry about the delay.


Re: utils.c:get_grouping_data calls strdup with a null pointer

2007-02-11 Thread Hrvoje Niksic
Thanks for the report.  Please note that your patch sets the thousands
separator to C, which is probably not what you had in mind.  I'm
about to apply a slightly different patch to deal with the problem you
describe:

2007-02-11  Hrvoje Niksic  [EMAIL PROTECTED]

* utils.c (get_grouping_data): Cope with systems where
localeconv() doesn't initialize lconv-thousand_sep and/or
lconv-grouping.  Based on report by Dirk Vanhaute.

Index: src/utils.c
===
--- src/utils.c (revision 2205)
+++ src/utils.c (working copy)
@@ -1215,8 +1215,8 @@
   /* Get the grouping info from the locale. */
   struct lconv *lconv = localeconv ();
   cached_sep = lconv-thousands_sep;
-  cached_grouping = lconv-grouping;
-  if (!*cached_sep)
+  cached_grouping = lconv-grouping ? lconv-grouping : \x03;
+  if (!cached_sep || !*cached_sep)
{
  /* Many locales (such as C or hr_HR) don't specify
 grouping, which we still want to use it for legibility.