Re: Myriad merges
Zitat von Micah Cowan [EMAIL PROTECTED]:
Zitat von Jochen Roderburg [EMAIL PROTECTED]:
So it looks now to me, that the new error (local timestamp not set to
remote)
only occurs in the cases when no HEAD is used.
This (new) piece of code in http.c (line 2666 ff.) looks very suspicious to
me,
especially the time_came_from_head bit:
/* Reparse time header, in case it's changed. */
if (time_came_from_head
hstat.remote_time hstat.remote_time[0])
{
newtmr = http_atotm (hstat.remote_time);
if (newtmr != -1)
tmr = newtmr;
}
The intent behind this code is to ensure that we parse the Last-Modified
date again, even if we already parsed Last-Modified, if the last one we
parsed came from the HEAD.
Hmm, yes, but that is not what it does ;-)
I mean, it does not parse the date again even if it was already parsed, but
only if it was already parsed. So especially it does *not* parse it if there
had been no HEAD at all before.
And the only other code I found which parses the remote date is in the part
which handles the logic around the timestamping option. In older versions this
was a conditional block starting with if (!got_head) ... , now it starts with
if (send_head_first !got_head) ... Could this mean that this code is now
only executed when a HEAD response is examined ??
Anyway, I think everything is ok again when you just eliminate this
time_came_from_head logic completely. The above piece of code then just sets
the local timestamp to the last remote timestamp which was seen and does not
care from which HEAD or GET requests it actually came.
Jochen Roderburg
ZAIK/RRZK
University of Cologne
Robert-Koch-Str. 10 Tel.: +49-221/478-7024
D-50931 Koeln E-Mail: [EMAIL PROTECTED]
Germany
Re: Announcing... The Wget Wgiki!
Josh Williams wrote: On 9/7/07, Micah Cowan [EMAIL PROTECTED] wrote: Doh! Of course, it's .org. Fortunately all the other links, including the ones from the site at gnu.org, seem to be correct. Unfortunately for you, your typo is now an official piece of free software history! :D Just poking. :-P D: -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer... http://micah.cowan.name/
Re: Announcing... The Wget Wgiki!
On 9/7/07, Micah Cowan [EMAIL PROTECTED] wrote: Doh! Of course, it's .org. Fortunately all the other links, including the ones from the site at gnu.org, seem to be correct. Unfortunately for you, your typo is now an official piece of free software history! :D Just poking. :-P
Re: Myriad merges
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Jochen Roderburg wrote:
Zitat von Micah Cowan [EMAIL PROTECTED]:
Zitat von Jochen Roderburg [EMAIL PROTECTED]:
So it looks now to me, that the new error (local timestamp not set to
remote)
only occurs in the cases when no HEAD is used.
This (new) piece of code in http.c (line 2666 ff.) looks very suspicious to
me,
especially the time_came_from_head bit:
/* Reparse time header, in case it's changed. */
if (time_came_from_head
hstat.remote_time hstat.remote_time[0])
{
newtmr = http_atotm (hstat.remote_time);
if (newtmr != -1)
tmr = newtmr;
}
The intent behind this code is to ensure that we parse the Last-Modified
date again, even if we already parsed Last-Modified, if the last one we
parsed came from the HEAD.
Hmm, yes, but that is not what it does ;-)
I mean, it does not parse the date again even if it was already parsed, but
only if it was already parsed. So especially it does *not* parse it if there
had been no HEAD at all before.
That's actually what I said it does (somewhat clumsily: if the last one
we parsed came from the HEAD).
Yes, as I said, if there had been no HEAD before, it should already have
been parsed in earlier code, and no action should be necessary. That's
what time_came_from_head is for, to prevent us from parsing it twice
from GET.
And the only other code I found which parses the remote date is in the part
which handles the logic around the timestamping option. In older versions this
was a conditional block starting with if (!got_head) ... , now it starts
with
if (send_head_first !got_head) ... Could this mean that this code is now
only executed when a HEAD response is examined ??
Hm... that change came from the Content-Disposition fixes. I'll investigate.
- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer...
http://micah.cowan.name/
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFG4XQO7M8hyUobTrERCEe3AJ9ywjfcxZl0a9vAQSWaBspuPsAXmQCdEflk
VQvp1HYcvm2gCE0ogJiD04I=
=SDe0
-END PGP SIGNATURE-
Re: Announcing... The Wget Wgiki!
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Senthil Kumaran S wrote: On 9/7/07, Micah Cowan [EMAIL PROTECTED] wrote: The main informational site for GNU Wget is now at http://wget.addictivecode.com/; the Wget Wgiki. Is it http://wget.addictivecode.com/ or http://wget.addictivecode.org/ ? I could not reach http://wget.addictivecode.com/ Doh! Of course, it's .org. Fortunately all the other links, including the ones from the site at gnu.org, seem to be correct. - -- Micah J. Cowan Programmer, musician, typesetting enthusiast, gamer... http://micah.cowan.name/ -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFG4XL77M8hyUobTrERCOdNAJ9tUWv90A1Y2QEcoFuNEhcuGh4wSACcDNFa PH7KuZUeTnAjG/C8fRaFYxQ= =84pn -END PGP SIGNATURE-
Re: Announcing... The Wget Wgiki!
On 9/7/07, Micah Cowan [EMAIL PROTECTED] wrote: The main informational site for GNU Wget is now at http://wget.addictivecode.com/; the Wget Wgiki. Is it http://wget.addictivecode.com/ or http://wget.addictivecode.org/ ? I could not reach http://wget.addictivecode.com/ -- Senthil Kumaran S http://www.stylesen.org
