--delete-after and --spider should not create (and leave) directories

2007-07-12 Thread Josh Williams

It has come to my attention that --delete-after and --spider leave
empty directories when they have finished. IMHO, we should force
--no-directories since we're not leaving any of the files we're
downloading.

I have submitted a patch here - https://savannah.gnu.org/bugs/index.php?20466

Do any of you have any objections to this change?


Re: [wget-notify] [bug #20466] --delete-after and --spider should not create (and leave) directories

2007-07-12 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256

Joshua David Williams wrote:
 URL:
   http://savannah.gnu.org/bugs/?20466

...

 Details:
 
 This patch forces the --no-directories option if we're not actually keeping
 the files we're downloading (as in the --delete-after and --spider options).
 This way, we don't leave a mess of empty directories.

This seems like a reasonable idea, but I'd like to get some discussion
on it first.

The downside, of course, is that there's no short option to reverse the
implied -nd; they'll have to use --directories (at the time I was
discussing it with Josh, I'd been thinking -e would be needed, but this
seems to be untrue).

It seems to me that by far the most common intention would be not to
leave any files around; this behavior seems fairly reason to me. Thoughts?

- --
Micah J. Cowan
Programmer, musician, typesetting enthusiast, gamer...
http://micah.cowan.name/

-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGlpx17M8hyUobTrERCKP5AJ4rHtoA7xy9FNidKS7WooTwmF5xGACfYHv2
fIwxjHVH/t3H6/xkVk4Yqio=
=ZbKt
-END PGP SIGNATURE-