Re: [PATCH] A working implementation of fork_to_background() under Windows – please test

2004-03-24 Thread David Fritz
Hrvoje Niksic wrote: Thanks for the patch, I've now applied it to CVS. You might want to add a comment in front of fake_fork() explaining what it does, and why. The comment doesn't have to be long, only several sentences so that someone reading the code later understands what the heck a "fake for

Re: [PATCH] A working implementation of fork_to_background() under Windows – please test

2004-03-24 Thread David Fritz
Hrvoje Niksic wrote: Thanks for the patch, I've now applied it to CVS. You might want to add a comment in front of fake_fork() explaining what it does, and why. The comment doesn't have to be long, only several sentences so that someone reading the code later understands what the heck a "fake for

Re: [PATCH] A working implementation of fork_to_background() under Windows – please test

2004-03-24 Thread David Fritz
Hrvoje Niksic wrote: For now I'd start with applying David's patch, so that people can test its functionality. It is easy to fix the behavior of `wget -q -b' later. David, can I apply your patch now? Sure. The attached patch corrects a few minor formatting details but is otherwise identical to t

RE: [PATCH] A working implementation of fork_to_background() under Windows – please test

2004-03-24 Thread Herold Heiko
> From: David Fritz [mailto:[EMAIL PROTECTED] > Subject: Re: [PATCH] A working implementation of fork_to_background() > The current patch attempts to emulate the behavior of the > Unix version. AFAICT, > this and the following suggestion apply equally well to the > existing (Unix) code. I ag

Re: [PATCH] A working implementation of fork_to_background() under Windows – please test

2004-03-23 Thread David Fritz
Herold Heiko wrote: MSVC binary at http://xoomer.virgilio.it/hherold/ for public testing. I performed only basic tests on NT4 sp6a, everything performed fine as expected. Thank you much for testing and hosting the binary. Some ideas on this thing: I'll respond to your points out-of-order. In verb

RE: [PATCH] A working implementation of fork_to_background() under Windows – please test

2004-03-23 Thread Herold Heiko
MSVC binary at http://xoomer.virgilio.it/hherold/ for public testing. I performed only basic tests on NT4 sp6a, everything performed fine as expected. Some ideas on this thing: In verbose mode the child should probably acknowledge in the log file the fact it was invocated as child. In debug mode