Re: Wget 1.11 build fails on old Linux

2008-03-31 Thread Alain Guibert
 On Monday, February 25, 2008 at 16:32:21 +0100, Alain Guibert wrote:

 On an old Debian Bo system (kernel 2.0.40, gcc 2.7.2.1, libc 5.4.33),
 building Wget 1.11 fails:

While wget 1.11.1 builds and works OK. Thank you very much, gentlemen!


Alain.


Wget 1.11 build fails on old Linux

2008-02-25 Thread Alain Guibert
Hello gentlemen,

On an old Debian Bo system (kernel 2.0.40, gcc 2.7.2.1, libc 5.4.33),
building Wget 1.11 fails:

| gcc -I. -I.   -DHAVE_CONFIG_H -DSYSTEM_WGETRC=\/usr/local/etc/wgetrc\ 
-DLOCALEDIR=\/usr/local/share/locale\ -O2 -Wall -c connect.c
| connect.c: In function `select_fd':
| connect.c:620: storage size of `tmout' isn't known
| connect.c:623: warning: implicit declaration of function `FD_ZERO'
| connect.c:624: warning: implicit declaration of function `FD_SET'
| connect.c:634: warning: implicit declaration of function `select'
| connect.c:620: warning: unused variable `tmout'
| connect.c: In function `test_socket_open':
| connect.c:655: storage size of `to' isn't known
| connect.c:655: warning: unused variable `to'
| make[1]: *** [connect.o] Error 1
| make[1]: Leaving directory `/tmp/wget-1.11/src'
| make: *** [src] Error 2

On such old platform, the needed definitions are in linux/time.h,
included by sys/time.h, included by time.h. At least one of them
used to be included by src/sysdep.h in Wget 1.10.2. But in Wget 1.11,
src/sysdep.h #includes time.h only #ifndef HAVE_TIMEGM. This platform
does HAVE_TIMEGM, but its select() still needs time.h.

Once src/sysdep.h reverted to #include time.h or sys/time.h as
before, Wget 1.11 compiles and works fine.


Alain.