Content-Disposition not working with input file

2007-07-05 Thread Jack Black
Hi list! Ive noticed that Content-Disposition header filenames are ignored when an input file is specified except for the first one. The file from the first link in the input file is stored with the right filename but the following files get saved as something like index.php ?sid=123123 I'm

Downloading 7GB-file via FTP

2007-07-05 Thread veejar
Hello! I use wgetpro-0.1.3_1 on FreeBSD 6.2 RELEASE. Command: wpro -c -b -i download.lst -Y off I try to download file with size ~7GB via FTP. First 2GB wget-pro downloaded sucessful, but then, after continning downloading I have found such text in logs:

RE: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Tony Lewis
There is a buffer overflow in the following line of the proposed code: sprintf(filecopy, \%.2047s\, file); It should be: sprintf(filecopy, \%.2045s\, file); in order to leave room for the two quotes. Tony -Original Message- From: Rich Cook [mailto:[EMAIL PROTECTED] Sent:

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Rich Cook
Good point, although it's only a POTENTIAL buffer overflow, and it's limited to 2 bytes, so at least it's not exploitable. :-) On Jul 5, 2007, at 9:05 AM, Tony Lewis wrote: There is a buffer overflow in the following line of the proposed code: sprintf(filecopy, \%.2047s\, file); It

RE: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Virden, Larry W.
-Original Message- From: Hrvoje Niksic [mailto:[EMAIL PROTECTED] Tony Lewis [EMAIL PROTECTED] writes: Wget has an `aprintf' utility function that allocates the result on the heap. Avoids both buffer overruns and arbitrary limits on file name length. If it uses the heap, then

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Hrvoje Niksic
Tony Lewis [EMAIL PROTECTED] writes: There is a buffer overflow in the following line of the proposed code: sprintf(filecopy, \%.2047s\, file); Wget has an `aprintf' utility function that allocates the result on the heap. Avoids both buffer overruns and arbitrary limits on file name

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Hrvoje Niksic
Rich Cook [EMAIL PROTECTED] writes: Trouble is, it's undocumented as to how to free the resulting string. Do I call free on it? Yes. Freshly allocated with malloc in the function documentation was supposed to indicate how to free the string.

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Hrvoje Niksic
Virden, Larry W. [EMAIL PROTECTED] writes: Tony Lewis [EMAIL PROTECTED] writes: Wget has an `aprintf' utility function that allocates the result on the heap. Avoids both buffer overruns and arbitrary limits on file name length. If it uses the heap, then doesn't that open a hole where a

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Rich Cook
Trouble is, it's undocumented as to how to free the resulting string. Do I call free on it? I'd use asprintf, but I'm afraid to suggest that here as it may not be portable. On Jul 5, 2007, at 10:45 AM, Hrvoje Niksic wrote: Tony Lewis [EMAIL PROTECTED] writes: There is a buffer overflow

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Rich Cook
On Jul 5, 2007, at 11:08 AM, Hrvoje Niksic wrote: Rich Cook [EMAIL PROTECTED] writes: Trouble is, it's undocumented as to how to free the resulting string. Do I call free on it? Yes. Freshly allocated with malloc in the function documentation was supposed to indicate how to free the

RE: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Bruso, John
Please remove me from this list. thanks, John Bruso From: Rich Cook [mailto:[EMAIL PROTECTED] Sent: Thu 7/5/2007 12:30 PM To: Hrvoje Niksic Cc: Tony Lewis; [EMAIL PROTECTED] Subject: Re: bug and patch: blank spaces in filenames causes looping On Jul 5,

Re: Downloading 7GB-file via FTP

2007-07-05 Thread Steven M. Schweda
From veejar: I use wgetpro-0.1.3_1 on FreeBSD 6.2 RELEASE. Great. How is that related to normal wget? On which wget version was it based? The current released version of wget, 1.10.2, should have no problems with large files, assuming that the FTP server and the local file system have

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Hrvoje Niksic
Rich Cook [EMAIL PROTECTED] writes: On Jul 5, 2007, at 11:08 AM, Hrvoje Niksic wrote: Rich Cook [EMAIL PROTECTED] writes: Trouble is, it's undocumented as to how to free the resulting string. Do I call free on it? Yes. Freshly allocated with malloc in the function documentation was

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Rich Cook
So forgive me for a newbie-never-even-lurked kind of question: will this fix make it into wget for other users (and for me in the future)? Or do I need to do more to make that happen, or...? Thanks! On Jul 5, 2007, at 12:52 PM, Hrvoje Niksic wrote: Rich Cook [EMAIL PROTECTED] writes:

Re: WGET Dev branch BROKEN

2007-07-05 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Christopher G. Lewis wrote: OK - (First of all, welcome to Micah - thanks for working with us :-) My pleasure! :-) Sorry I didn't catch this earlier, but it looks like something broke in the dev branch recently. I've got a batch

wget dev versioning [Re: WGET Dev branch BROKEN]

2007-07-05 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Micah Cowan wrote: Christopher G. Lewis wrote: I've got a batch that autobuilds the SVN dev tree and posts the results to my windows wget page. Part of that build is to grab the cacert.PEM from the curl site. Recently, the SRC\WGET.EXE

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rich Cook wrote: So forgive me for a newbie-never-even-lurked kind of question: will this fix make it into wget for other users (and for me in the future)? Or do I need to do more to make that happen, or...? Thanks! Well, I need a chance to

wget-patches status?

2007-07-05 Thread Micah Cowan
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 What is the status of the wget-patches list: is it being actively used/monitored? Does it still serve its original purpose? A brief glance at the archives seems to suggest that, for one reason or another, it may be suffering a larger spam problem

Re: bug and patch: blank spaces in filenames causes looping

2007-07-05 Thread Rich Cook
Thanks for the follow up. :-) On Jul 5, 2007, at 3:52 PM, Micah Cowan wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Rich Cook wrote: So forgive me for a newbie-never-even-lurked kind of question: will this fix make it into wget for other users (and for me in the future)? Or do