Re: Crash

2007-05-29 Thread Hrvoje Niksic
Adrian Sandor <[EMAIL PROTECTED]> writes:

> Thanks a lot Steven,
>
>> Apparently there's more than a little code in src/cookies.c which is
>> not ready for NULL values in the "attr" and "value" members of the
>> "cookie" structure.
>
> Does that mean wget is buggy or does brinkster break the cookie
> specification?

Probably both, but Wget is definitely buggy since it crashes.  Looking
at the code, it would appear the bug has been fixed in the repository.


Re: Crash

2007-05-28 Thread Steven M. Schweda
From: Adrian Sandor

> > Apparently there's more than a little code in src/cookies.c which is
> > not ready for NULL values in the "attr" and "value" members of the
> > "cookie" structure.
> 
> Does that mean wget is buggy or does brinkster break the cookie specification?

   Wget is certainly buggy, but as I said, I don't do much with cookies,
so I don't know if missing/null values are legal or not.

> I tried it, and it solves my problem.

   Glad to hear it.  Thanks for the report.

>  Will there be an official wget
> patch for this?

   Ask the wget maintainer.  I can't even get the changes _I_ want into
the official code.



   Steven M. Schweda   [EMAIL PROTECTED]
   382 South Warwick Street(+1) 651-699-9818
   Saint Paul  MN  55105-2547


Re: Crash

2007-05-28 Thread Adrian Sandor
Thanks a lot Steven, 

> Apparently there's more than a little code in src/cookies.c which is
> not ready for NULL values in the "attr" and "value" members of the
> "cookie" structure.

Does that mean wget is buggy or does brinkster break the cookie specification?

 > Double your money back if you're not completely satisfied,

I am satisfied, but I took my money back just in case :)

> if you can build from the sources, you could try this one:

I tried it, and it solves my problem. Will there be an official wget patch for 
this?

Thanks
Adrian





  
Fussy?
 Opinionated? Impossible to please? Perfect.  Join Yahoo!'s user panel and lay 
it on us. http://surveylink.yahoo.com/gmrs/yahoo_panel_invite.asp?a=7 


Re: Crash

2007-05-28 Thread Steven M. Schweda
From: Adrian Sandor

> [...]
> Stored cookie www14.brinkster.com -1 (ANY) /aditsu/   
> [expiry none] (null) (null)
> [...]
> Segmentation fault

   Apparently there's more than a little code in src/cookies.c which is
not ready for NULL values in the "attr" and "value" members of the
"cookie" structure.  (It's more luck than design that you get "(null)"
in the debug message, instead of it blowing up right there.)

   Double your money back if you're not completely satisfied, but, if
you can build from the sources, you could try this one:

  http://antinode.org/ftp/wget/wget-1_10_2c_vms/cookies.c

I don't do much with cookies, so the end cases may not be handled
correctly, but it does seem to explode less.  (If nothing else, it could
boost the ego of the next fellow who does it right.)



   Steven M. Schweda   [EMAIL PROTECTED]
   382 South Warwick Street(+1) 651-699-9818
   Saint Paul  MN  55105-2547