Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-29 Thread Ian Hickson
On Wed, 16 Apr 2014, Boris Zbarsky wrote: Right now canvas drawImage ignores EXIF orientation metadata. Could we add a version that doesn't do that? Especially with CSS growing things like the image-orientation property, it would be good to support drawing the image in its correct

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-17 Thread Jonas Sicking
On Wed, Apr 16, 2014 at 8:09 AM, Anne van Kesteren ann...@annevk.nl wrote: On Wed, Apr 16, 2014 at 3:45 PM, Justin Novosad ju...@google.com wrote: I was wondering the same thing. From the image-orientation spec: It applies only to content images (e.g. replaced elements and generated content),

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-17 Thread Glenn Maynard
On Thu, Apr 17, 2014 at 2:46 AM, Jonas Sicking jo...@sicking.cc wrote: The problem here stemms from that orientation data lives as metadata in the EXIF data of image formats. This means that many tools has simply ignored that metadata. The result seems to have been that people open their

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Justin Novosad
+1 But why a new version of drawImage? Couldn't we just modify the existing drawImage definition to state that it takes into account the image-orientation property on the source image? The default value for image-orientation is 0deg, which corresponds to the current drawImage behavior. So I

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Anne van Kesteren
On Wed, Apr 16, 2014 at 3:22 PM, Justin Novosad ju...@google.com wrote: But why a new version of drawImage? Couldn't we just modify the existing drawImage definition to state that it takes into account the image-orientation property on the source image? The default value for image-orientation

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Justin Novosad
On Wed, Apr 16, 2014 at 7:26 AM, Anne van Kesteren ann...@annevk.nl wrote: On Wed, Apr 16, 2014 at 3:22 PM, Justin Novosad ju...@google.com wrote: But why a new version of drawImage? Couldn't we just modify the existing drawImage definition to state that it takes into account the

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Boris Zbarsky
On 4/16/14 10:22 AM, Justin Novosad wrote: But why a new version of drawImage? Couldn't we just modify the existing drawImage definition to state that it takes into account the image-orientation property on the source image? We could do that, though it introduces a dependency of drawImage on

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Anne van Kesteren
On Wed, Apr 16, 2014 at 3:45 PM, Justin Novosad ju...@google.com wrote: I was wondering the same thing. From the image-orientation spec: It applies only to content images (e.g. replaced elements and generated content), not decorative images (such as background-image). So this property

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Boris Zbarsky
On 4/16/14 11:09 AM, Anne van Kesteren wrote: I don't really follow the reasoning. But I guess if this has been shipping in Firefox for a while we might be out of luck changing this. I doubt image-orientation is widely used, esp. in combination with drawImage. But if we want to use it here,

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Justin Novosad
Another use case to think about is: XHR-Blob-ImageBitmap-Canvas(2D or WebGL) With that data flow, there is no opportunity to use a CSS property to tweak image orientation. There is this idea though: http://wiki.whatwg.org/wiki/ImageBitmap_Options Boris' point about adding a dependency on style

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Anne van Kesteren
On Wed, Apr 16, 2014 at 5:54 PM, Justin Novosad ju...@google.com wrote: From an implementation standpoint though, it would make sense for image elements to to store decoded images with the corrected orientation baked-in, and to be able to use that cached decoded image buffer directly in

Re: [whatwg] canvas drawImage and EXIF orientation metadata

2014-04-16 Thread Justin Novosad
On Wed, Apr 16, 2014 at 10:57 AM, Anne van Kesteren ann...@annevk.nlwrote: On Wed, Apr 16, 2014 at 5:54 PM, Justin Novosad ju...@google.com wrote: From an implementation standpoint though, it would make sense for image elements to to store decoded images with the corrected orientation

[whatwg] canvas drawImage and EXIF orientation metadata

2014-04-15 Thread Boris Zbarsky
Right now canvas drawImage ignores EXIF orientation metadata. Could we add a version that doesn't do that? Especially with CSS growing things like the image-orientation property, it would be good to support drawing the image in its correct orientation. -Boris