Re: [whatwg] RadioNodeList and buttons

2017-11-05 Thread RĂ©gis Kuckaertz
Hi Boris - That's awesome, thank you.

On Fri, Nov 3, 2017 at 6:23 PM Boris Zbarsky  wrote:

> On 10/31/17 10:56 AM, Regis Kuckaertz wrote:
> > Indeed I find your idea more appealing and semantically clearer.
>
> OK, good.  Since it's not just me, I filed
> https://github.com/whatwg/html/issues/3195 on this.
>
> -Boris
>


Re: [whatwg] RadioNodeList and buttons

2017-11-03 Thread Boris Zbarsky

On 10/31/17 10:56 AM, Regis Kuckaertz wrote:

Indeed I find your idea more appealing and semantically clearer.


OK, good.  Since it's not just me, I filed 
https://github.com/whatwg/html/issues/3195 on this.


-Boris


Re: [whatwg] RadioNodeList and buttons

2017-10-31 Thread Regis Kuckaertz
Thanks for your question. Phrased like that, it becomes clear to me that I
did not think enough about how the value would be computed in the case of a
set of buttons. There is no "checkedness" in buttons, not that I know of.

Indeed I find your idea more appealing and semantically clearer. When I
wrote the example, I thought the name attribute on buttons was redundant
with the type attribute.

On Tue, 31 Oct 2017 at 14:23 Boris Zbarsky  wrote:

> On 10/31/17 6:23 AM, Regis Kuckaertz wrote:
> > formElement.onsubmit = (evt) => {
> >evt.preventDefault();
> >const button = evt.target.elements.namedItem('action');
> >const value = button.value
>
> If this returned buttons, which button would you expect it to return in
> various situations and why?
>
> > Here is my question: if the UA handles this situation without a glitch,
> > wouldn't you expect the corresponding DOM API to expose the same
> behaviour?
>
> I just checked one UA (Firefox), and the way it handles this situation
> is that it stores the "submitter" (in the sense of the argument to
> ) on the
> "submit" event itself.  Exposing it as a property on that event would
> make a lot of sense to me.
>
> -Boris
>

-- 

--
This e-mail and all attachments are confidential and may also be 
privileged. If you are not the named recipient, please notify the sender 
and delete the e-mail and all attachments immediately. Do not disclose the 
contents to another person. You may not use the information for any 
purpose, or store, or copy, it in any way.  Guardian News & Media Limited 
is not liable for any computer viruses or other material transmitted with 
or as part of this e-mail. You should employ virus checking software.
 
Guardian News & Media Limited is a member of Guardian Media Group plc. 
Registered 
Office: PO Box 68164, Kings Place, 90 York Way, London, N1P 2AP.  Registered 
in England Number 908396




Re: [whatwg] RadioNodeList and buttons

2017-10-31 Thread Boris Zbarsky

On 10/31/17 6:23 AM, Regis Kuckaertz wrote:

formElement.onsubmit = (evt) => {
   evt.preventDefault();
   const button = evt.target.elements.namedItem('action');
   const value = button.value


If this returned buttons, which button would you expect it to return in 
various situations and why?



Here is my question: if the UA handles this situation without a glitch,
wouldn't you expect the corresponding DOM API to expose the same behaviour?


I just checked one UA (Firefox), and the way it handles this situation 
is that it stores the "submitter" (in the sense of the argument to 
) on the 
"submit" event itself.  Exposing it as a property on that event would 
make a lot of sense to me.


-Boris