[ 
https://issues.apache.org/jira/browse/WICKET-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495289
 ] 

Matej Knopp commented on WICKET-192:
------------------------------------

I think the current way is not difficult :) This is okay for open / close 
leaves icons, but what if you have different icon for each node type? (e.g. 
file browser). Then it's much better IMHO to do it in java.


> make it easier to customize node icons in the tree
> --------------------------------------------------
>
>                 Key: WICKET-192
>                 URL: https://issues.apache.org/jira/browse/WICKET-192
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.2.4, 1.3, 2.0
>            Reporter: Igor Vaynberg
>         Assigned To: Matej Knopp
>             Fix For: 1.3
>
>
> looking at how the tree works now, we are inlining the url to the node icon 
> into the markup in newNodeIcon(). so if the user wants to customize the icon 
> images they have to do it through code which is a pita imho. it would be 
> better if instead of inlining resource urls we would set a css class 
> attribute, then users can provide their own stylesheet. 
> then we need to figure out a way to make it easy to silence the tree's own 
> css contribution so the user can override it with their own.
> make sense?
> its a lot easier for me to do <style>div.my-nav-tree div.wicket-tree 
> span.node-expanded { background-url: {foo.png}}</style> then have to register 
> my own wicket resource, override getNodeIcon(), etc

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to