[jira] Updated: (WICKET-622) Component.toString() is unsafe
[ https://issues.apache.org/jira/browse/WICKET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alastair Maw updated WICKET-622: Fix Version/s: (was: 1.2.7) (was: 1.3.0-beta1) 1.3.0-rc1 Hmmm, this is still an issue in trunk, now I look. I think toString() on Component should call toString(false). Worse, toString(false) on MarkupContainer calls super.toString(true) regardless. It's difficult to get Eclipse to tell me what calls .toString() ;-) I guess we should just turn detailed output off and call it explicitly when we find we need it, or when people whinge. > Component.toString() is unsafe > --- > > Key: WICKET-622 > URL: https://issues.apache.org/jira/browse/WICKET-622 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.2 >Reporter: Nili Adoram > Fix For: 1.3.0-rc1 > > > I add a component to its container when the page is initialized, BEFORE > it is rendered and before page model finished to initialize. > if log4j is configured to enable wicket debug, the container toString() > is called. > This method invokes isVisible() of the container. > I have overridden isVisible(), to query the page model before deciding > whether the component is actually visible. > I assumed this method is called when the component is rendered, and by > that time the model is completely initialized. > However, since it was called before component rendering, my code failed > and the page failed to be created. > To sum up, toString() of Component should be safe. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-622) Component.toString() is unsafe
[ https://issues.apache.org/jira/browse/WICKET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alastair Maw updated WICKET-622: Fix Version/s: (was: 1.3.0-rc1) 1.3.0-beta1 > Component.toString() is unsafe > --- > > Key: WICKET-622 > URL: https://issues.apache.org/jira/browse/WICKET-622 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.2 >Reporter: Nili Adoram > Fix For: 1.2.7, 1.3.0-beta1 > > > I add a component to its container when the page is initialized, BEFORE > it is rendered and before page model finished to initialize. > if log4j is configured to enable wicket debug, the container toString() > is called. > This method invokes isVisible() of the container. > I have overridden isVisible(), to query the page model before deciding > whether the component is actually visible. > I assumed this method is called when the component is rendered, and by > that time the model is completely initialized. > However, since it was called before component rendering, my code failed > and the page failed to be created. > To sum up, toString() of Component should be safe. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-622) Component.toString() is unsafe
[ https://issues.apache.org/jira/browse/WICKET-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alastair Maw updated WICKET-622: Fix Version/s: 1.3.0-rc1 1.2.7 > Component.toString() is unsafe > --- > > Key: WICKET-622 > URL: https://issues.apache.org/jira/browse/WICKET-622 > Project: Wicket > Issue Type: Bug > Components: wicket >Affects Versions: 1.2.2 >Reporter: Nili Adoram > Fix For: 1.2.7, 1.3.0-rc1 > > > I add a component to its container when the page is initialized, BEFORE > it is rendered and before page model finished to initialize. > if log4j is configured to enable wicket debug, the container toString() > is called. > This method invokes isVisible() of the container. > I have overridden isVisible(), to query the page model before deciding > whether the component is actually visible. > I assumed this method is called when the component is rendered, and by > that time the model is completely initialized. > However, since it was called before component rendering, my code failed > and the page failed to be created. > To sum up, toString() of Component should be safe. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
