Re: License headers v2

2006-11-18 Thread Johan Compagner
that's one of the strangest requirements if you ask me. Why oh why do you want to force that it needs to be a binary inclusion only? Thats very strange for an opensource thing... But rewriting that.. its a file with almost only static finals.. rewriting that means that you pretty much type it

i18n message loading

2006-11-18 Thread Eelco Hillenius
Hi all, I'm writing a chapter on internationalization/ localization, and found out the message loading works differently from what I expected (and I'm quite sure how it used to work pre 1.2?). The first thing I stumbled on was the fact that messages are located searching from parent to child

Re: License headers v2

2006-11-18 Thread Eelco Hillenius
But rewriting that.. its a file with almost only static finals.. rewriting that means that you pretty much type it over What we could do, and what imo would be a bit nicer, is instead of a general bucket of client properties (backed by a map), just implement those properties as actual

Re: i18n message loading

2006-11-18 Thread Johan Compagner
we should first go through it for the given language and then do it for the default language But quickly looking at that. That won't be an easy fix, because the iteration through components is in Localizer and the iteration over locale/style is in XxxxStringResourceLoader My personal opinion

Re: i18n message loading

2006-11-18 Thread Eelco Hillenius
On 11/18/06, Johan Compagner [EMAIL PROTECTED] wrote: we should first go through it for the given language and then do it for the default language But quickly looking at that. That won't be an easy fix, because the iteration through components is in Localizer and the iteration over locale/style

Re: i18n message loading

2006-11-18 Thread Igor Vaynberg
i think that was done so you can override properties of deeper components. suppose i create a custom component, and this component uses key my.key in its markup and provides a default value in its .properties file. so how do you override that? right now its simple, just redefine my.key in the

Re: i18n message loading

2006-11-18 Thread Juergen Donnerstag
I remember we had endless discussions on the sequence of finding properties and I'm not able to recall all of them. I'm not aware of any changes to the code for quite a while. And as it has been fairly silent with respect to users asking questions or requesting functionality, means to me that

Re: i18n message loading

2006-11-18 Thread Eelco Hillenius
On 11/18/06, Igor Vaynberg [EMAIL PROTECTED] wrote: i think that was done so you can override properties of deeper components. suppose i create a custom component, and this component uses key my.key in its markup and provides a default value in its .properties file. so how do you override

Re: i18n message loading

2006-11-18 Thread Juergen Donnerstag
To Johans point, I think the current implementation is too inflexible, it is far to difficult to change/extend/limit the search order easily if required. IMO this general design problem needs to be fixed. Yep, I agree. The logic should be brought back to one place. So... we could open an

Re: i18n message loading

2006-11-18 Thread Eelco Hillenius
On 11/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: To Johans point, I think the current implementation is too inflexible, it is far to difficult to change/extend/limit the search order easily if required. IMO this general design problem needs to be fixed. Yep, I agree. The logic

Re: i18n message loading

2006-11-18 Thread Juergen Donnerstag
It has been on my todo list for a long time already. It's just lack of time Juergen On 11/18/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 11/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: To Johans point, I think the current implementation is too inflexible, it is far to difficult

Re: License headers v2

2006-11-18 Thread Frank Bille
There is an issue report for it now, so in time if noone has done anything about it I will. But at the moment I'm trying to get this license header fun task done. So anyone please submit patches for WICKET-87 if you feel like it :) Frank On 11/18/06, Eelco Hillenius [EMAIL PROTECTED] wrote:

failing junit tests

2006-11-18 Thread Juergen Donnerstag
WebRequestCodingStrategyTest and CookieValuePersisterTest are failing. Mind someone looking into it. Thanks Juergen

Re: New property expression langauge: MVEL

2006-11-18 Thread Chris Brock
You should note that the actual template parser and expression parser are completely different. The template parser itself has control-flow constructs, but the expression parser alone does not. Also, you can even drill down and just use the PropertyAccessor in MVEL. So it's possible to

Re: New property expression langauge: MVEL

2006-11-18 Thread Igor Vaynberg
i guess the question is: what will we get by using this that we dont already have? -igor On 11/18/06, Chris Brock [EMAIL PROTECTED] wrote: You should note that the actual template parser and expression parser are completely different. The template parser itself has control-flow