Re: [Vote] wicket modules

2007-02-19 Thread Jonathan Locke
if you're installing them explicitly, you have a nice type-safe constructor with code completion help. and if you do need a config parameter later you can add it and everyone on earth will know what happened. igor.vaynberg wrote: unlike jmx this isnt part of core, so if you dont want to

Re: [Vote] wicket modules

2007-02-19 Thread Jonathan Locke
yes. the generalization is what i'm more afraid of here... igor.vaynberg wrote: i guess another thing to consider is that in both of these cases there are no sideeffects of installing these things. if you dont use the annots everything is as it was before. so its not like you drop this

Re: [Vote] wicket modules

2007-02-19 Thread Jonathan Locke
h. i'm a bit slow this morning. the reason you want to change authorization is because auto module initialization doesn't permit easy parameters to the module such as: add(new WicketModuleAnnotatedRoleSecurity(Application.this, ...)); (or whatever name best fits this module) Jonathan

Re: [Vote] wicket modules

2007-02-19 Thread Igor Vaynberg
you can have multiple strategies easily working together. just keep looping through them until you get a false out of one (a veto) and then stop. if no false then it passes - true. just what a compound strat would do. but setonce and exception wont work. then module can never set one, so we lose

Re: [Vote] wicket modules

2007-02-19 Thread Jonathan Locke
we do disagree. i don't believe in the ability of module designers to create modules that seamlessly interoperate. we had this problem almost 20 years ago with windows hooks and it was a complete disaster. i've seen it repeated in other places in oo systems and it's a mess there too. i think

Re: [Vote] wicket modules

2007-02-19 Thread Igor Vaynberg
yes, on large scale maybe. i am talking about small self-contained modules. and this isnt really InstallHook :) not all approaches like this are bad. eclipse/osgi is one example where there are a ton of tiny modules that work together really well. -igor On 2/19/07, Jonathan Locke [EMAIL

Re: [Vote] wicket modules

2007-02-18 Thread Jonathan Locke
I like the idea of snap-in modules of some sort, but I don't completely understand what you're talking about here and I'm not sure I agree with what all of what I do get. I'm unsure about auto-installing modules using the classpath. With the classpath loading, you wind up with a lot of magic

Re: [Vote] wicket modules

2007-02-18 Thread Igor Vaynberg
i disagree. having things explicit is very nice when there is a need for you to know, but what if there isnt? take wicket-spring module. its only service is to make fields annotated with @SpringBean injectable. why should the user care that this is done with the componentinstantiationlistener,

Re: [Vote] wicket modules

2007-02-18 Thread Igor Vaynberg
i guess another thing to consider is that in both of these cases there are no sideeffects of installing these things. if you dont use the annots everything is as it was before. so its not like you drop this file in and all of a sudden things get weird. -igor On 2/18/07, Igor Vaynberg [EMAIL

Re: [Vote] wicket modules

2007-02-18 Thread Igor Vaynberg
unlike jmx this isnt part of core, so if you dont want to activate it dont put it on your classpath. furthermore, like i said, there are no sideffects in activating it. the only downside i can think of is how to configure these things. usually you would do it when installing them, but when they