Re: [Wicket-develop] property models and private field access

2006-09-05 Thread Igor Vaynberg
can you check it into 2.0 now, and into 1.3 once we switch-IgorOn 9/5/06, Frank Bille <[EMAIL PROTECTED] > wrote:+1 for 2.0 1.3-1 for 1.2 On 9/5/06, Johan Compagner <[EMAIL PROTECTED] > wrote: fine by me. I altered PropertyResolver and added some test i had to change some behaviour now because tes

Re: [Wicket-develop] property models and private field access

2006-09-05 Thread Frank Bille
+1 for 2.0 1.3-1 for 1.2On 9/5/06, Johan Compagner <[EMAIL PROTECTED]> wrote: fine by me. I altered PropertyResolver and added some test i had to change some behaviour now because testMapSizeLookup() was failing nowbecause findField does find much more then then before.But all test are running fine

Re: [Wicket-develop] property models and private field access

2006-09-05 Thread Johan Compagner
fine by me. I altered PropertyResolver and added some test i had to change some behaviour now because testMapSizeLookup() was failing nowbecause findField does find much more then then before.But all test are running fine. Is this wanted in 1.x or just in 2.0?johanOn 9/5/06, Juergen Donnerstag <[E

Re: [Wicket-develop] property models and private field access

2006-09-04 Thread Juergen Donnerstag
+1 Juergen On 9/5/06, Matej Knopp <[EMAIL PROTECTED]> wrote: > I'm +1 too. > > -Matej > > Eelco Hillenius wrote: > > I'd be +1 for that. Now that Hibernate, Spring, etc all allow access > > to private fields, I wouldn't feel bad about supporting that. > > > > Eelco > > > > > > On 9/4/06, Igor Vay

Re: [Wicket-develop] property models and private field access

2006-09-04 Thread Matej Knopp
I'm +1 too. -Matej Eelco Hillenius wrote: > I'd be +1 for that. Now that Hibernate, Spring, etc all allow access > to private fields, I wouldn't feel bad about supporting that. > > Eelco > > > On 9/4/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: >> should we let our property models access to pr

Re: [Wicket-develop] property models and private field access

2006-09-04 Thread Eelco Hillenius
I'd be +1 for that. Now that Hibernate, Spring, etc all allow access to private fields, I wouldn't feel bad about supporting that. Eelco On 9/4/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > should we let our property models access to private fields? > > often i have constructs like > > class My

[Wicket-develop] property models and private field access

2006-09-04 Thread Igor Vaynberg
should we let our property models access to private fields?often i have constructs likeclass MyPage {  private String str;   new PropertyModel(this, "str");} it sucks to have public getters and setters for "str" because it breaks encapsulation and beacuse i hate that they take up space in