HiCan somebody look if it works for him on their browser?I changed the new window detection for a pagemap by setting in _javascript_ cookies (with the pagemap name as cookie name)now on a page load we set a cookie and on a
body.onUnLoad we delete the cookie again.So when the page is still there an
The first issue I ran into is a page did not have a body tag. It'll
give a null pointer exception, and even if we would ignore that the
script wouldn't work. I think there is no way for us to know where the
body tags should go, so if there's no body tag, log a warning and
don't render the script? O
IMO each page should have a . I not 100% sure but I expect more
problems to pop up for pages without body tag. And I don't think they
can easily be automatically inserted. Adding caused me already
enough headaches
Juergen
On 4/14/06, Eelco Hillenius <[EMAIL PROTECTED]> wrote:
> The first issue I
yeah.. a webpage with no body tag?then lots of other things could go wrong that are depending on the body onload event...I can make a test that if the body container is not there i revert to the previous/old method.
johan On 4/14/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote:
IMO each page shoul
On 4/14/06, Juergen Donnerstag <[EMAIL PROTECTED]> wrote:
> IMO each page should have a . I not 100% sure but I expect more
> problems to pop up for pages without body tag. And I don't think they
> can easily be automatically inserted. Adding caused me already
> enough headaches
Hehe. Poor Juerge
added a body container null check to revert to previous behaviour (same as no cookies found)On 4/14/06, Eelco Hillenius <
[EMAIL PROTECTED]> wrote:On 4/14/06, Juergen Donnerstag <
[EMAIL PROTECTED]> wrote:> IMO each page should have a . I not 100% sure but I expect more> problems to pop up for page
Damn. That means that I have to sort out the SVN conflict now. You
beat me! Anyway, I'm working on logging a warning about missing a body
tag.
Eelco
On 4/14/06, Johan Compagner <[EMAIL PROTECTED]> wrote:
> added a body container null check to revert to previous behaviour (same as
> no cookies fou
Feature Requests item #1470631, was opened at 2006-04-14 23:54
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting:
https://sourceforge.net/tracker/?func=detail&atid=684978&aid=1470631&group_id=119783
Please note that this message will contain
