Re: [Wicket-user] VOTE: one more api break for AbstractChoice

2005-07-29 Thread Eelco Hillenius
+1 Eelco Johan Compagner wrote: We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer renderer) I want to change it to: public AbstractChoice(final String id, IModel model, final IModel choices, final IChoiceRenderer renderer) So

Re: [Wicket-user] VOTE: one more api break for AbstractChoice

2005-07-29 Thread Juergen Donnerstag
+1 Juergen On 7/29/05, Eelco Hillenius [EMAIL PROTECTED] wrote: +1 Eelco Johan Compagner wrote: We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer renderer) I want to change it to: public AbstractChoice(final

Re: [Wicket-user] VOTE: one more api break for AbstractChoice

2005-07-29 Thread Crash_neo
+/- 0 (+1) I like the option discussed in the wicket 1.1b2-rc1 string. keep both and make the old one deprecated. But if you can't have both, then break Johan Compagner wrote: We now have: public AbstractChoice(final String id, IModel model, final List choices, final IChoiceRenderer

RE: [Wicket-user] VOTE: one more api break for AbstractChoice

2005-07-29 Thread Igor Vaynberg
+1 the javadoc should be clear that the underlying model object needs to be a list or whatever. It would be nice to switch to imodelt right now. -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Johan Compagner Sent: Friday, July 29, 2005 4:33 AM

Re: [Wicket-user] VOTE: one more api break for AbstractChoice

2005-07-29 Thread Johan Compagner
that is not an option (using generics) i think this will be an option After 1.2 not earlier because wicket is a framework that will be used on servers and servers are pretty slow to adapt to new java versions. Especially things like Websphere where versions are build on a specific jvm I will