Re: [Wicket-user] Link to anchor?

2006-06-02 Thread Eelco Hillenius
Sorry, that's not implemented yet. It's filed here http://sourceforge.net/tracker/index.php?func=detailaid=1491239group_id=119783atid=684978 When someone of us can find time for it, we'll implement it for the 1.2 branch and the 2.0 branch. Eelco On 6/1/06, Ali Zaid [EMAIL PROTECTED] wrote:

Re: [Wicket-user] Link to Anchor

2006-05-18 Thread Eelco Hillenius
Yeah, I like that. I'll try to give it a look today. Eelco On 5/18/06, nato [EMAIL PROTECTED] wrote: So, would the named anchor be supported in the next version of Wicket? BTW, I vote for Link.setAnchor() so that I could set the anchor dynamically. I also vote for the proposed a

Re: [Wicket-user] Link to Anchor

2006-05-17 Thread nato
So, would the named anchor be supported in the next version of Wicket?BTW, I vote for Link.setAnchor() so that I could set the anchor dynamically. I also vote for the proposed a href="" wicket:id=anchoredLinkan href with # followed by a word is automatically an anchor/a is IMO benificial too.

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Johan Compagner
So something like this?Link: protected final void onComponentTag(final ComponentTag tag) { // Default handling for tag super.onComponentTag(tag); // Set href to link to this link's linkClicked method CharSequence url = "">String maybeAnchor = tag.getAttributes().getString(href);

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Vincent Jenks
+1 - I think that's pretty cool! Couldn't that be done w/ an ExternalLink? AttributeModifier? On 5/11/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Yeah, I like that idea. So, if the contents of the url start with #, we append that to the url... that's the idea, right? What do other people

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Andrew Berman
I'd rather have a setter added to Link called setAnchor which appends the #anchor automatically to the url. On 5/11/06, Vincent Jenks [EMAIL PROTECTED] wrote:+1 - I think that's pretty cool!Couldn't that be done w/ an ExternalLink?AttributeModifier? On 5/11/06, Eelco Hillenius [EMAIL PROTECTED]

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Ayodeji Aladejebi
Link.setAnchor () +1 dabar On 5/11/06, Andrew Berman [EMAIL PROTECTED] wrote: I'd rather have a setter added to Link called setAnchor which appends the #anchor automatically to the url. On 5/11/06, Vincent Jenks [EMAIL PROTECTED] wrote: +1 - I think that's pretty cool!Couldn't that be done

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Ali Zaid
Hay Guys; Glad you like the idea, as for adding a setter, I don't think it's any different than overridding the method as above, as wicket always does, it uses what in HTML, and this will help in design time too. On 5/11/06, Andrew Berman [EMAIL PROTECTED] wrote: I'd rather have a setter added

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Eelco Hillenius
On 5/11/06, Ali Zaid [EMAIL PROTECTED] wrote: Hay Guys; Glad you like the idea, as for adding a setter, I don't think it's any different than overridding the method as above, as wicket always does Yeah, you got a point there too. So we don't have to add the property, unless it's a clear win

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Philip A. Chapman
You might want to check for content after the #. As a general rule, I put # in the href of my template's a tags. I picked that up from examples and such. I think it'd work fine to have the # hanging on the end, but there's no need for it. On Thu, 2006-05-11 at 08:21 -0600, Vincent Jenks

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Igor Vaynberg
yeaha href="" wicket:id=blahyou need that # so the link renders like a link when you preview in the browser.-IgorOn 5/11/06, Philip A. Chapman [EMAIL PROTECTED] wrote: You might want to check for content after the #. As a general rule, I put # in the href of my template's a tags. I

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Philip A. Chapman
I guess it wouldn't be too hard to satisfy both camps? if setLink() isn't called, look in the template to see if an anchor was indicated. if setLink() was called, use the passed value. Is that too much black magic? On Thu, 2006-05-11 at 19:16 +0300, Ali Zaid wrote: Hay Guys; Glad you like

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Andrew Berman
The only reason why I like the setAnchor over overriding the getUrl() method is that it gives it a more standard feel to add anchors. Overriding getUrl() to me signifies that you really want to do something more complicated to the URL than just adding an anchor. Just my two cents. On 5/11/06, Igor

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Ali Zaid
in prevoius post I did suggest to check what after #, I would also like to suggest adding something like setResponsePage(somePage, someAnchor), it may not only be needed for a link, we may need to jump to that anchor after sumitting a link :), don't hate me guys ;) On 5/11/06, Igor Vaynberg

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Ali Zaid
Sorry, I ment submitting a formOn 5/11/06, Ali Zaid [EMAIL PROTECTED] wrote: in prevoius post I did suggest to check what after #, I would also like to suggest adding something like setResponsePage(somePage, someAnchor), it may not only be needed for a link, we may need to jump to that anchor

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Eelco Hillenius
What about both? Btw, I'm not sure whether anchor is the best name, as any a tag technically is an anchor. That said, I wouldn't know an alternative. So, what we could do is use that property if it is set. If it is not set we look at whether the attribute value starts with #, and when that's not

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Ali Zaid
I don't see why we can't have both, but really, I think we need to set anchors in setResponsePage() too, it will be good for forms too. On 5/11/06, Eelco Hillenius [EMAIL PROTECTED] wrote: What about both? Btw, I'm not sure whether anchor is the best name, as any a tag technically is an anchor.

Re: [Wicket-user] Link to Anchor

2006-05-11 Thread Eelco Hillenius
Yeah, I do that all the time too. But having an url that ends with # is no problem. Though, if nothing comes behind it we might ditch it too. Eelco On 5/11/06, Igor Vaynberg [EMAIL PROTECTED] wrote: yeah a href=# wicket:id=blah you need that # so the link renders like a link when you