Re: [Wicket-user] Re: expand emty tags

2005-08-28 Thread Jesse Sightler
So the concern now is performance? Is this really meaningful? If there is a substantial performance penalty for it, wouldn't that just mean that Wicket is already slow? On 8/27/05, Juergen Donnerstag [EMAIL PROTECTED] wrote: it is not. for open-close tags like span/ onBodyRender is simply

Re: [Wicket-user] Re: expand emty tags

2005-08-28 Thread Gili
Well... I don't think a performance loss actually matters in this case. Think about it... if there *is* a body when there shouldn't be and we throw an exception it tends to be fatal anyway. Doing this extra check should not seriously affect the performance of tags which render properly. For

Re: [Wicket-user] Re: expand emty tags

2005-08-27 Thread Jesse Sightler
I still don't agree at all. I think at the very least this should throw an exception. Ie, why is it legal to add a body to an XML element that doesn't allow one?On 8/26/05, Phil Kulak [EMAIL PROTECTED] wrote: Hmm... it would make sense if there were a distinction between theempty string and null

Re: [Wicket-user] Re: expand emty tags

2005-08-27 Thread Juergen Donnerstag
it is not. for open-close tags like span/ onBodyRender is simply not called and thus no output is generated and for the same reason we can not check if there is but shouldn't. We are either fast and efficient or slow but with better error messages. Juergen On 8/28/05, Jesse Sightler [EMAIL

Re: [Wicket-user] Re: expand emty tags

2005-08-26 Thread Juergen Donnerstag
We used to have that some time ago and users complaint about the magic, which didn't fit there use case. Currently it is easy: we do not automatically convert span/ into span. We do not change any tag automatically. And because a span/ has no body, onComponentBody is not called either. Juergen

Re: [Wicket-user] Re: expand emty tags

2005-08-26 Thread Gwyn Evans
Hmm, sounds logical when you put it that way! :-) /Gwyn On 26/08/05, Juergen Donnerstag [EMAIL PROTECTED] wrote: We used to have that some time ago and users complaint about the magic, which didn't fit there use case. Currently it is easy: we do not automatically convert span/ into span. We

Re: [Wicket-user] Re: expand emty tags

2005-08-26 Thread Phil Kulak
Yea, but span/span also has no body. On 8/26/05, Juergen Donnerstag [EMAIL PROTECTED] wrote: We used to have that some time ago and users complaint about the magic, which didn't fit there use case. Currently it is easy: we do not automatically convert span/ into span. We do not change any tag

Re: [Wicket-user] Re: expand emty tags

2005-08-26 Thread Juergen Donnerstag
hmm? the body is isn't it? On 8/26/05, Phil Kulak [EMAIL PROTECTED] wrote: Yea, but span/span also has no body. On 8/26/05, Juergen Donnerstag [EMAIL PROTECTED] wrote: We used to have that some time ago and users complaint about the magic, which didn't fit there use case. Currently it is

Re: [Wicket-user] Re: expand emty tags

2005-08-26 Thread Phil Kulak
Hmm... it would make sense if there were a distinction between the empty string and null in XML. You're probably right. On 8/26/05, Juergen Donnerstag [EMAIL PROTECTED] wrote: hmm? the body is isn't it? On 8/26/05, Phil Kulak [EMAIL PROTECTED] wrote: Yea, but span/span also has no body.