Re: [Widelands-dev] *** GMX Spamverdacht *** Re: Regression tests

2014-07-30 Thread Holger Rapp
On 30.07.2014, at 21:06, Fòram na Gàidhlig wrote: > 30/07/2014 18:31, sgrìobh Holger Rapp: >> >> On 30.07.2014, at 11:46, Fòram na Gàidhlig > > wrote: >> >>> Since we have 1 central file now - maybe just mention that one on an >>> appropriate Wiki page, so peop

Re: [Widelands-dev] Regression tests

2014-07-30 Thread Fòram na Gàidhlig
30/07/2014 18:31, sgrìobh Holger Rapp: > > On 30.07.2014, at 11:46, Fòram na Gàidhlig > wrote: > >> Since we have 1 central file now - maybe just mention that one on an >> appropriate Wiki page, so people will know it's there? > > In my experience nobody reads t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1348795 into lp:widelands

2014-07-30 Thread SirVer
Review: Needs Fixing I like the refactorings, but there is at least one bug and a couple of design suggestions. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1348795/+merge/228430 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1348795. _

[Widelands-dev] [Merge] lp:~hjd/widelands/unused-value into lp:widelands

2014-07-30 Thread Hans Joachim Desserud
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/unused-value into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~hjd/widelands/unused-value/+merge/228921 Removed variable assignment happening just before re

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/furnace into lp:widelands

2014-07-30 Thread Hans Joachim Desserud
Unsurprisingly, nothing in scripting. I checked tribes when changing the names/moving directories. -- https://code.launchpad.net/~widelands-dev/widelands/furnace/+merge/227810 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/furnace. ___

Re: [Widelands-dev] Regression tests

2014-07-30 Thread Holger Rapp
On 30.07.2014, at 11:46, Fòram na Gàidhlig wrote: > Since we have 1 central file now - maybe just mention that one on an > appropriate Wiki page, so people will know it's there? In my experience nobody reads the Wiki :). I think it is better to point it out in code reviews and encourage people

Re: [Widelands-dev] Fwd: can find any more resources

2014-07-30 Thread Fòram na Gàidhlig
>> 2014-07-29 20:46 GMT+02:00 Fòram na Gàidhlig > >: >> >> I've done a bit of refactoring today in this branch: >> >> https://code.launchpad.net/~widelands-dev/widelands/bug-1348795 >> >> Check out the new ProductionSite::out_of_resources function - when

Re: [Widelands-dev] Regression tests

2014-07-30 Thread Fòram na Gàidhlig
Since we have 1 central file now - maybe just mention that one on an appropriate Wiki page, so people will know it's there? 30/07/2014 05:24, sgrìobh SirVer: > > On 29.07.2014, at 09:41, GunChleoc wrote: > >> This is the first time anybody has mentioned that particular Python script >> to me.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1348795 into lp:widelands

2014-07-30 Thread GunChleoc
Review: Resubmit This is ready for review again. - Changed 2 protected char* buffers to private strings. - Added "Out Of Fields" etc. tooltip - Refactored ProductionProgram::ActMine::notify_player and ProductionSite::worker_failed_to_find_resource - Fixed codecheck warnings & NOCOMs -- http