Review: Approve
I only skimmed this since Tibor already approved, but I did not see anything
that stood out negative. I also ran it real quick and like the new menu
structure - the teams graphics are awesome! Though I would change the headline
to read "Suggested teams" or "Balanced team suggest
Review: Approve
Solid change! Lots of small but impactful improvements here.
Diff comments:
> === modified file 'src/base/scoped_timer.cc'
> --- src/base/scoped_timer.cc 2014-07-05 13:14:42 +
> +++ src/base/scoped_timer.cc 2014-10-27 10:39:23 +
> @@ -33,8 +33,8 @@
>
> ScopedTimer::~
Sounds to me like removing the localedir is a good idea then. It could be that
some packagers complain, but we can always bring it back as a compile time
option then.
Also, what about compile.sh? Does it build locales? If so, we need a symlink
from the datadir to the created locale directory.
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1385859 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1385859/+merge/239705
To avoid occasional crashes, c_str() is no lon
Review: Approve
For me it looks OK, you have my approve
--
https://code.launchpad.net/~widelands-dev/widelands/i18nfixes/+merge/238137
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/i18nfixes.
___
Mailing list: http
Glad we found it :)
So, this should be ready for merging now?
--
https://code.launchpad.net/~widelands-dev/widelands/i18nfixes/+merge/238137
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/i18nfixes.
___
Mailing list
6 matches
Mail list logo
