[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_geometry into lp:widelands

2014-11-26 Thread SirVer
SirVer has proposed merging lp:~widelands-dev/widelands/cleanup_geometry into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/cleanup_geometry/+merge/242888 Suggested commit message: Cleaned up

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_geometry into lp:widelands

2014-11-26 Thread GunChleoc
Review: Approve We should turn the int type thing into a general cleanup task with clear guidelines. I have tended to use uin8_t especially for enum classes, because it will save on memory. However, uint8_t also involves a lot of type casts, e.g. with boost::format. I lack the experience to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-768826 into lp:widelands

2014-11-26 Thread GunChleoc
No, that was just me being lazy when I added it to the debug screen. -- https://code.launchpad.net/~widelands-dev/widelands/bug-768826/+merge/242544 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-768826. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-768826 into lp:widelands

2014-11-26 Thread TiborB
OK, going to hide it -- https://code.launchpad.net/~widelands-dev/widelands/bug-768826/+merge/242544 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-768826. ___ Mailing list: https://launchpad.net/~widelands-dev

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_geometry into lp:widelands

2014-11-26 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/cleanup_geometry into lp:widelands has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/cleanup_geometry/+merge/242888 -- Your team Widelands Developers is subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_geometry into lp:widelands

2014-11-26 Thread SirVer
I filed bug 1396756 for this with my thoughts on the topic. I think discussion should continue there. -- https://code.launchpad.net/~widelands-dev/widelands/cleanup_geometry/+merge/242888 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/cleanup_geometry.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380286 into lp:widelands

2014-11-26 Thread TiborB
TiborB has proposed merging lp:~widelands-dev/widelands/bug-1380286 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1380286 in widelands: Roads of a flag should be accessible in Lua scripting https://bugs.launchpad.net/widelands/+bug/1380286

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-768826 into lp:widelands

2014-11-26 Thread TiborB
@GunChleoc: done, can check it now :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-768826/+merge/242544 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-768826. ___ Mailing list: