Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380286 into lp:widelands

2014-12-04 Thread SirVer
Do you really want to reimplement all that is available in C to lua? No, only what makes sense. Asking a flag if it knows about a warehouse somewhere in its road network makes no sense to me. Option 1) is clearer, but it is also more work. I would suggest removing get_warehouse from this

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380286 into lp:widelands

2014-12-04 Thread TiborB
As we are not in hurry, I will unpropose merge and add that economy staff -- https://code.launchpad.net/~widelands-dev/widelands/bug-1380286/+merge/242975 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1380286.

[Widelands-dev] [Merge] lp:~willyscheibel/widelands/use-glbinding into lp:widelands

2014-12-04 Thread Willy Scheibel
Willy Scheibel has proposed merging lp:~willyscheibel/widelands/use-glbinding into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~willyscheibel/widelands/use-glbinding/+merge/243642 Add possibility to compile and run

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/codecheck_sort into lp:widelands

2014-12-04 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/codecheck_sort into lp:widelands has been updated. Commit Message changed to: Added codecheck rule to include algorithm when std::sort is used. For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_game_renderer into lp:widelands

2014-12-04 Thread GunChleoc
Review: Approve Fixed 2 nits myself + tested. LGTM. I love these graphic changes, Widelands is now noticeably faster on my machine. -- https://code.launchpad.net/~widelands-dev/widelands/cleanup_game_renderer/+merge/243124 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_game_renderer into lp:widelands

2014-12-04 Thread SirVer
Thanks for the review and the fixes. :) I love these graphic changes, Widelands is now noticeably faster on my machine. Great, that keeps me motivated. -- https://code.launchpad.net/~widelands-dev/widelands/cleanup_game_renderer/+merge/243124 Your team Widelands Developers is subscribed

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/cleanup_game_renderer into lp:widelands

2014-12-04 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/cleanup_game_renderer into lp:widelands has been updated. Status: Needs review = Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/cleanup_game_renderer/+merge/243124 -- Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~hjd/widelands/remove-sdl2-gfx into lp:~widelands-dev/widelands/debian

2014-12-04 Thread SirVer
Review: Approve should be save to merge. sdl_gfx is definitively no longer used. -- https://code.launchpad.net/~hjd/widelands/remove-sdl2-gfx/+merge/243727 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/debian. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

2014-12-04 Thread TiborB
@GunChleoc Thanks for testing:) 1. In fact the ship algorithm (I mean not part of AI) sometimes incorectly reports islandcircumnavigated (signal), even though nothing were circumnavigated, only banks are too close. And AI is not able to find out the the signal is errorneous. When I tested