Review: Needs Fixing
> I kept the file names in case a change would break savegames.
Should be save I think - win conditions are loaded on game start and then are
part of the Lua state and are therefore persisted with the savegame. If the
display logic in the menus is not trying to load the fil
Review: Needs Information
> Treat game entities as proper names in tutorials, campaigns and scenarios.
Why? I just skimmed this so far, but Well and Bakery reads strange to me.
--
https://code.launchpad.net/~widelands-dev/widelands/bug-1406301/+merge/247513
Your team Widelands Developers is su
Review: Needs Fixing
I did a codereview now and I identified one bug in the AI: it will not work
properly after loading. See code review comments. I think this is not ideal,
but not critical. After the NOCOMs are removed this should be merged and a new
branch should deal with the design issue.
The proposal to merge lp:~widelands-dev/widelands/bug-1374831 into lp:widelands
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1374831/+merge/248092
--
Your team Widelands Developers is subscribed to branch
lp
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1408775 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1408775 in widelands: "Make autocrat & territorial lord the last win
conditions, make Collectors the first "
https://bugs.lau
Review: Approve
Diff comments:
> === modified file 'src/editor/tools/editor_info_tool.cc'
> --- src/editor/tools/editor_info_tool.cc 2014-11-27 07:53:21 +
> +++ src/editor/tools/editor_info_tool.cc 2015-01-30 10:42:02 +
> @@ -26,6 +26,7 @@
> #include "base/i18n.h"
> #include
of course
I tested only AI-only games, because I dont have enough time for a real game...
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/seafaring-ai.
__
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/small-fixes into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/small-fixes/+merge/248165
Fixes a warning and unifies and picks one version of t
I'll prioritize looking over this tomorrow. There are some changes outside of
ai/ that I'd like to think through before they hit trunk.
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/wide
The proposal to merge lp:~hjd/widelands/unused-option into
lp:~widelands-dev/widelands/debian has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~hjd/widelands/unused-option/+merge/248152
--
Your team Widelands Developers is subscribed to bran
@GunChleoc
first NOCOM is perhaps a mistake??
and second one was discussed with SirVer and I think this is no problem and I
might remove it.
But I will wait for another review and comments
--
https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271
Your team Widelands Dev
Review: Approve
The parameter rings a bell. LGTM.
--
https://code.launchpad.net/~hjd/widelands/unused-option/+merge/248152
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/debian.
___
Mailing list: https://launchpad.n
Hans Joachim Desserud has proposed merging lp:~hjd/widelands/unused-option into
lp:~widelands-dev/widelands/debian.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~hjd/widelands/unused-option/+merge/248152
Looks like this wasn't caugh
My testing was done to see if anything crashes, and to check if behaviour is
OK. I think it is OK for now - I just decided to give detailed feedback so we
know what can be improved further.
Once the 2 remaining NOCOMS are fixed, I think this branch is ready to be
merged :)
--
https://code.laun
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1374831 into
lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1374831 in widelands: "Terrain names in terrains/init.lua incosistent"
https://bugs.launchpad.net/widelands/+bug/1374831
For
15 matches
Mail list logo
