Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

Review: Approve I have moved the ScoutingDirection enum into ship.h and fixed up the code so it won't get used as boolean. Everything else LGTM. -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

Review: Needs Fixing Houston, we have e problem: test_rip_first_port_with_worker_in_portdock.lua hangs. -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-ai.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

Review: Resubmit I thought these are brand new tests you just created, nevermind... :) BUT - I compiled trunk, run the tests and they failed on the very test. So no regression here... -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271 Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

So I looked at your tests - I liked them much, two comments about the issue: 1.) I think this is not AI related - at all 2.) I would say the lua is not correct, and I am not sure what is to be tested. When you extend the sleeps - you can see how the ship picks a worker from port1 and if port2

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1380286 into lp:widelands

I have pushed a code review. Just split up the tests, and we're good to go. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1380286/+merge/242975 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1380286.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

I see the same as SirVer - tests work in trunk. -- https://code.launchpad.net/~widelands-dev/widelands/seafaring-ai/+merge/242271 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/seafaring-ai. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/seafaring-ai into lp:widelands

BUT - I compiled trunk, run the tests and they failed on the very test. So no regression here... not what I see - the test passes for me on trunk and hangs forever in seafaring-ai. It could be something in the new logic of re-adding the portdock to a warehouse. --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1406301 into lp:widelands

GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1406301 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1406301 in widelands: Various strings need fixing https://bugs.launchpad.net/widelands/+bug/1406301 For more details, see:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/split_lua_table into lp:widelands

Review: Approve I have added a needed include. Compiles and runs without problems otherwise. -- https://code.launchpad.net/~widelands-dev/widelands/split_lua_table/+merge/248192 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/split_lua_table.