Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-scheduler into lp:widelands

2015-03-05 Thread GunChleoc
Review: Approve Thanks. LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/ai-scheduler/+merge/251327 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ai-scheduler. ___ Mailing list: https://launchpad.net/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-scheduler into lp:widelands

2015-03-05 Thread TiborB
OK, the time reworked - I hope without hidden negative consequencies -- https://code.launchpad.net/~widelands-dev/widelands/ai-scheduler/+merge/251327 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/ai-scheduler into lp:widelands. _

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/copyright-file into lp:~widelands-dev/widelands/debian

2015-03-05 Thread Hans Joachim Desserud
The proposal to merge lp:~widelands-dev/widelands/copyright-file into lp:~widelands-dev/widelands/debian has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/copyright-file/+merge/245297 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/copyright-file into lp:~widelands-dev/widelands/debian

2015-03-05 Thread Hans Joachim Desserud
No problem Martin, that's completely understandable. Thanks for letting us know. :) In the meantime, I'll just put this branch on ice, and we'll get back to it when we have a better idea on how to proceed. I'll try to adjust the review status so that it doesn't show up in the list of active rev

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-scheduler into lp:widelands

2015-03-05 Thread GunChleoc
game().get_gametime() should return uint32_t. We just haven't gotten around to fixing it. https://bugs.launchpad.net/widelands/+bug/1380058 -- https://code.launchpad.net/~widelands-dev/widelands/ai-scheduler/+merge/251327 Your team Widelands Developers is requested to review the proposed merge o

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-998544 into lp:widelands

2015-03-05 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-998544 into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #998544 in widelands: "Replay name should contain Widelands version" https://bugs.launchpad.net/widelands/+bug/998544 For more

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-scheduler into lp:widelands

2015-03-05 Thread TiborB
uf, not a big problem, I am just afraid that some of these variables can achieve (or start with) negative values now - but I will test it all... also a side question: game().get_gametime() returns int32_t - that means range of gametime -24 - +24 days. I hope game stops itself after 24 days of g

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ai-scheduler into lp:widelands

2015-03-05 Thread GunChleoc
Looks like a good solution to me :) I have added a bunch of small nits with the comments function. Diff comments: > === modified file 'src/ai/defaultai.cc' > --- src/ai/defaultai.cc 2015-02-16 20:23:15 + > +++ src/ai/defaultai.cc 2015-03-04 20:14:13 + > @@ -50,12 +50,6 @@ >