Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395322-tool3 into lp:widelands

2016-04-05 Thread Miroslav Remák
If we're going to be so specific, we should also mention that Shift or Ctrl + Click removes map elements for Immovables, Animals and Port Space tools. Except Ctrl + Click with the Port Space tool does placement instead of removal for some reason. Perhaps we could fix this inconsistency? That

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526911-cursor-positioning into lp:widelands

2016-04-05 Thread Miroslav Remák
Review: Approve code Looks good code-wise. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1526911-cursor-positioning/+merge/290954 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1526911-cursor-positioning.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395322-tool3 into lp:widelands

2016-04-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 969. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/120978837. Appveyor build 802. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395322-tool3 into lp:widelands

2016-04-05 Thread kaputtnik
Review: Approve testing Great :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1395322-tool3/+merge/290829 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1395322-tool3. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526911-cursor-positioning into lp:widelands

2016-04-05 Thread kaputtnik
Review: Approve testing I think this is much better :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1526911-cursor-positioning/+merge/290954 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1526911-cursor-positioning.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395322-tool3 into lp:widelands

2016-04-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 968. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/120930924. Appveyor build 801. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-05 Thread SirVer
Lgtm!! Thanks :) > Am 05.04.2016 um 11:03 schrieb Klaus Halfmann : > > Ready for merge, any objections? > > SirVer, can you appove? > -- > https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 > You are subscribed to branch

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526911-cursor-positioning into lp:widelands

2016-04-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 967. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/120912395. Appveyor build 800. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526911-cursor-positioning into lp:widelands

2016-04-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 962. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/120833342. Appveyor build 795. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 -- Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-05 Thread GunChleoc
Thanks for cleaning up after me and for adding the documentation. I don't think we need SirVer to look at this personally now. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-05 Thread Klaus Halfmann
Ready for merge, any objections? SirVer, can you appove? -- https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/travis-clang-warnings.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1538549-dismantle-enemy-buildings into lp:widelands

2016-04-05 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1538549-dismantle-enemy-buildings into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1538549-dismantle-enemy-buildings/+merge/290895 -- Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1526911-cursor-positioning into lp:widelands

2016-04-05 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1526911-cursor-positioning into lp:widelands. Commit message: Some cursor fixes for edit boxes: - Fixed cursor y position for empty Editboxes. - Moved test for empty player names from editor player tool to map saving. - In a new

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1538549-dismantle-enemy-buildings into lp:widelands

2016-04-05 Thread GunChleoc
No, no there shouldn't be a conflict. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1538549-dismantle-enemy-buildings/+merge/290895 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1538549-dismantle-enemy-buildings.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1538549-dismantle-enemy-buildings into lp:widelands

2016-04-05 Thread bunnybot
Continuous integration builds have changed state: Travis build 961. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/120671195. Appveyor build 794. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-05 Thread Klaus Halfmann
Uhm, the fix for bug-1562332 was somehow reverted, I will add it in this branch again -- https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/travis-clang-warnings.