Review: Needs Fixing regression test
OK, here is the Backtrace,
I think Appvoyer found something similar.
Widelands::EditorGameBase::create_immovable(Widelands::Coords, unsigned char,
Widelands::MapObjectDescr::OwnerType) + 160 (editor_game_base.cc:360)
Review: Needs Information
* When setting some options I get:
[] Section [global], key 'depth' not used (did you spell the name correctly?)
[] Section [global], key 'ui_font' not used (did you spell the name correctly?)
[] Section [global], key 'speed_of_new_game' not used (did you spell the name
Continuous integration builds have changed state:
Travis build 997. State: failed. Details:
https://travis-ci.org/widelands/widelands/builds/122177123.
Appveyor build 830. State: success. Details:
Review: Approve review/compile
Moste of the code is correct, we mave some "Upgrades" form 8bit to 32bit,
that where broken before but got unnoticed, but now they will become visible.
Please check my inline comments
Id really like to have some coverage tool that checks that this code is actually
GunChleoc has proposed merging
lp:~widelands-dev/widelands/bug-1545243-plnum-lua into lp:widelands.
Commit message:
Some data type improvements:
- Fixed PlayerNumber datatype in Lua interface.
- New named datatype "Quantity" for ware/worker quantity.
- More consistent use of DescriptionIndex and
5 matches
Mail list logo
