Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands

2016-04-16 Thread Klaus Halfmann
hope I fixed the codecheck issues now. -- https://code.launchpad.net/~widelands-dev/widelands/bug_1571009_work_area_radius/+merge/292066 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands. ___

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands

2016-04-16 Thread bunnybot
Continuous integration builds have changed state: Travis build 1020. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/123553136. Appveyor build 852. State: failed. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_1571009_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands

2016-04-16 Thread Miroslav Remák
Diff reply. Diff comments: > > === modified file 'src/scripting/lua_map.cc' > --- src/scripting/lua_map.cc 2016-04-11 06:45:29 + > +++ src/scripting/lua_map.cc 2016-04-16 12:42:55 + > @@ -1871,10 +1871,16 @@ > /* RST > .. attribute:: workarea_radius > > - (

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands

2016-04-16 Thread Klaus Halfmann
Thanks for the hints Diff comments: > > === modified file 'src/scripting/lua_map.cc' > --- src/scripting/lua_map.cc 2016-04-11 06:45:29 + > +++ src/scripting/lua_map.cc 2016-04-16 12:42:55 + > @@ -1871,10 +1871,16 @@ > /* RST > .. attribute:: workarea_radius > > -

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands

2016-04-16 Thread Miroslav Remák
See diff comments. Diff comments: > > === modified file 'src/scripting/lua_map.cc' > --- src/scripting/lua_map.cc 2016-04-11 06:45:29 + > +++ src/scripting/lua_map.cc 2016-04-16 12:42:55 + > @@ -1871,10 +1871,16 @@ > /* RST > .. attribute:: workarea_radius > > -

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands

2016-04-16 Thread Klaus Halfmann
Klaus Halfmann has proposed merging lp:~widelands-dev/widelands/bug_1571009_work_area_radius into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1571009 in widelands: "Work area radius: 45xxx in bzr7962[trunk]" https://bugs.launchpad.net/widelan

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/revise-map-descr into lp:widelands

2016-04-16 Thread bunnybot
Continuous integration builds have changed state: Travis build 1018. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/123520813. Appveyor build 850. State: success. Details: https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_revise_map_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revise-map-descr into lp:widelands

2016-04-16 Thread kaputtnik
Got a crash when trying to access a folder in 'editor load map' and 'New game': terminate called after throwing an instance of 'RT::SyntaxErrorImpl' what(): Syntax error at 1:65: expected an allowed tag, got 'parent'. String continues with: '' > 1. Fixed Yeah :-) > > 2. There are obsolete in

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revise-map-descr into lp:widelands

2016-04-16 Thread GunChleoc
1. Fixed > 2. There are obsolete information: "Map size" and "2/3/4/... Player map". > These information is always in the table, so why should we have it in the > description again? We also use this in Editor-> Save Map. Do you think the information is useless there as well? There are 3 ways we