Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

Please leave a short comment when you merge force to explain why it was necessary and why you are confident that the branch is green. > Am 12.11.2017 um 08:23 schrieb GunChleoc : > > @bunnybot merge force > -- >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

@bunnybot merge force -- https://code.launchpad.net/~widelands-dev/widelands/clang-tidy-round1/+merge/333560 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/clang-tidy-round1. ___ Mailing list:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

Refusing to merge, since Travis is not green. Use @bunnybot merge force for merging anyways. Travis build 2794. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/300705679. -- https://code.launchpad.net/~widelands-dev/widelands/clang-tidy-round1/+merge/333560 Your team

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

Continuous integration builds have changed state: Travis build 2794. State: errored. Details: https://travis-ci.org/widelands/widelands/builds/300705679. Appveyor build 2605. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/codecheck_translations into lp:widelands

Continuous integration builds have changed state: Travis build 2792. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/300649551. Appveyor build 2603. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/check_representative_image into lp:widelands

The next thing we need to do is to triage the crashes from our game. I have compiled a branch for it to start testing, but then got sidetracked with another branch. It's important to search existing bugs for each of them too, so we won't create duplicates. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/clang-tidy-round1 into lp:widelands

It's a unique_ptr, so I've killed the line. Thanks for the review! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/clang-tidy-round1/+merge/333560 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/clang-tidy-round1.

Re: [Widelands-dev] [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands

> Thanks for the fix! > > Looks good to me - can you please replace UI::RenderedText::Shared with > std::shared_ptr and get rid of the new using statement? I > think that would make the code easier to read. Sure, I can do that. --

Re: [Widelands-dev] [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands

Thanks for the fix! Looks good to me - can you please replace UI::RenderedText::Shared with std::shared_ptr and get rid of the new using statement? I think that would make the code easier to read. -- https://code.launchpad.net/~flegu/widelands/r8481-renderedtext-memory-leaks/+merge/333578 Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/codecheck_translations into lp:widelands

GunChleoc has proposed merging lp:~widelands-dev/widelands/codecheck_translations into lp:widelands. Commit message: Added 2 codecheck rules for translation markup. - Ensure that translators' comments are immediately above their translations. - Detect inconsistent tag format for translators'

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/codecheck_translations into lp:widelands

The proposal to merge lp:~widelands-dev/widelands/codecheck_translations into lp:widelands has been updated. Commit Message changed to: Added 2 codecheck rules for translation markup. - Ensure that translators' comments are immediately above their translations. - Detect inconsistent tag format

[Widelands-dev] [Merge] lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands

Jukka Pakarinen has proposed merging lp:~flegu/widelands/r8481-renderedtext-memory-leaks into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~flegu/widelands/r8481-renderedtext-memory-leaks/+merge/333578 Valgrind

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/check_representative_image into lp:widelands

I have some vacation the next two weeks, so I start reviewing things like this branch. Looks straight forward. I will look around a bit to better understand the code. @Gun: if you have some issue that could need some more attention debugging please conatct me, I now cca (with some efforts) Debug