The proposal to merge lp:~widelands-dev/widelands/allows_seafaring_performance
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/allows_seafaring_performance/+merge/342987
--
Your team Widelands
Review: Approve review, compile, automated test
allows_seafaring_performance$ ./regression_test.py -b ./widelands
...
test/maps/two_ponds.wmf/scripting/test_seafaring.lua ...
Running Widelands ... done.
Loading savegame: port_spaces ... done.
ok
...
Ran 41 tests in 1204.108s
@bunnybot
Thanks for the review :)
Can you trigger the merge once your testing is done?
--
https://code.launchpad.net/~widelands-dev/widelands/allows_seafaring_performance/+merge/342987
Your team Widelands Developers is requested to review the proposed merge of
This is a prerequisite for the smaller_building_statistics branch.
checking this out now ...
Code is reasonable.
As this change carries its own testcase it can go in
once the test works for me.
--
https://code.launchpad.net/~widelands-dev/widelands/allows_seafaring_performance/+merge/342987
Continuous integration builds have changed state:
Travis build 3369. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/364989186.
Appveyor build 3175. State: success. Details:
Review: Resubmit
I know - I have taken care of it. Branch is ready; I'll put it up for review as
soon as Launchpad has finished parsing it.
https://code.launchpad.net/~widelands-dev/widelands/allows_seafaring_performance
--
GunChleoc has proposed merging
lp:~widelands-dev/widelands/allows_seafaring_performance into lp:widelands.
Commit message:
Only recalculate whether a map allows seafaring when something has changed
- New function Map::recalculate_allows_seafaring()
- Map::allows_seafaring() is recalculated:
-
7 matches
Mail list logo
