[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands

2018-08-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/fix-frisian-trainingsites-food-help/+merge/352977 -- Your

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3802. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/416115952. Appveyor build 3601. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1776603_map_info_memory_leak into lp:widelands

2018-08-14 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1776603_map_info_memory_leak into lp:widelands. Commit message: Added cleanup function to map_info.cc and initializing the sound system. This gets rid of some error messages and a memory leak. Pulled out common code for the website

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread GunChleoc
> SirVer, Gun: do we have that Ticket still in some Archive? There is nothing relevant with the "macos" tag in the archive. Of course, such a bug might have been fix released before I did the tag cleanup. --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3801. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/416088423. Appveyor build 3600. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3800. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/416061570. Appveyor build 3599. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help into lp:widelands

2018-08-14 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fix-frisian-trainingsites-food-help/+merge/352977 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix-frisian-trainingsites-food-help. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Toni Förster
Here are the clang builds: http://fosuta.org/widelands_64bit_r8786.dmg http://fosuta.org/widelands_64bit_r8786_Debug.dmg -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Klaus Halfmann
I rember that SirVer used brew as well for R19 and I used macports and we had some significat differences in the end, was much bigger, or such. SirVer, Gun: do we have that Ticket still in some Archive? Once we target R20 we should use all variants and use the smalles/fastest on. Lets see. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Toni Förster
$ ./build_app.sh clang debug ../macos_build_app_compiler gives me this output later on -- Using AddressSanitizer http://clang.llvm.org/docs/AddressSanitizer.html So it is using it without explicitly declaring it. Does work with clang. gcc currently gives me headaches, though. It seems to use

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Klaus Halfmann
Mmh, this does not contain the ASAN Flags as we have them in compile.sh, this would make sense for a debug build (yes, it _is_ slower :-) OTOH wee need this just for the release in then End, I would guess. I use macports so lets try this now wlbuild klaus$ ./build_app.sh clang debug

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread Klaus Halfmann
Toni, you re doing a great job! Just give me some time to catch up with your speed :-) You may contact me via PM or such, so we can align on our skills. Ill try to review this this week but will not promise anything ... --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ferry into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3790. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415596858. Appveyor build 3589. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3791. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415624736. Appveyor build 3590. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3796. State: failed. Details: https://travis-ci.org/widelands/widelands/builds/415851588. Appveyor build 3595. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_executable_bit into lp:widelands

2018-08-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/remove_executable_bit into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/remove_executable_bit/+merge/353012 -- Your team Widelands Developers is

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/remove_executable_bit into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3789. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415567854. Appveyor build 3588. State: failed. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition into lp:widelands

2018-08-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition/+merge/349594 --

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1619402-port-work-area-on-expedition into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3788. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415541252. Appveyor build 3587. State: success. Details:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread hessenfarmer
@ypopezios: In principle you are right. It is somewhat arbitrary or you might say it is try and error. On the other hand I don't know how to handle this in a different way, cause more frequent calls of the working programs will always consume more processing power. so the value of 500 to 1000ms

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3787. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415539866. Appveyor build 3586. State: success. Details:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands

2018-08-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/lenient_allowed_buildings into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/lenient_allowed_buildings/+merge/351749 -- Your team Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread ypopezios
In principle, if I was given a range to compromise with, I would go the conservative route and pick the edge of the range which is closer to the previous value. In this case, the given range is 500 to 1000ms, the previous value is 1ms, so I would go with 1000ms. Having said that, in my

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread Toni Förster
> Looks good from my side now. > Would be good though if somebody with an underpowered machine would confirm > minimal effect on performance Do you think it gets much more underpowered. Your processor is basically the same as mine. Just a few MHz slower. The only difference is RAM. --

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/missing_animations_barbarians_wood_hardener into lp:~widelands-dev/widelands/mines-worldsavior

2018-08-14 Thread hessenfarmer
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/missing_animations_barbarians_wood_hardener/+merge/352980 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/mines-worldsavior. ___ Mailing list:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1786613-500ms-return-skipped into lp:widelands

2018-08-14 Thread hessenfarmer
Review: Approve Looks good from my side now. Would be good though if somebody with an underpowered machine would confirm minimal effect on performance -- https://code.launchpad.net/~widelands-dev/widelands/bug-1786613-500ms-return-skipped/+merge/353028 Your team Widelands Developers is

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/macos_build_app_compiler into lp:widelands

2018-08-14 Thread GunChleoc
Review: Approve Code LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/macos_build_app_compiler/+merge/353035 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/macos_build_app. ___ Mailing list:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-14 Thread noreply
The proposal to merge lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1785404-chat-scrolling/+merge/352941 -- Your team Widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1785404-chat-scrolling into lp:widelands

2018-08-14 Thread bunnybot
Continuous integration builds have changed state: Travis build 3786. State: passed. Details: https://travis-ci.org/widelands/widelands/builds/415538286. Appveyor build 3585. State: success. Details: