Continuous integration builds have changed state:
Travis build 4101. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/438116698.
Appveyor build 3897. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_macos_buil
Continuous integration builds have changed state:
Travis build 4100. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/438094146.
Appveyor build 3896. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_cmakepolic
Toni Förster has proposed merging
lp:~widelands-dev/widelands/macos_build_app_SDK into lp:widelands.
Commit message:
Use MacOSX.sdk if an appropriate versioned SDK can't be found.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widela
I set a fixed version now: 3.9.2. That's the one that is used to compile the
macOS nightlies. The Version range does not seem to work as describe, although
it should be backwards-compatible (maybe I just misread something)
This does not fix the warning kaputtnik reported. Apparently Widelands ca
Review: Approve
OK, the portraits work as designed.
But as we already have a real Islnad could we have some +/- real Perons
portrait, too?
Like https://de.wikipedia.org/wiki/Aldgisl
Or from here: https://www.youtube.com/watch?v=cVZjSD6_WIQ
Or from some local Museum?
Fell free to merge, thou
Continuous integration builds have changed state:
Travis build 4099. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/437958798.
Appveyor build 3895. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_fri_portr
Continuous integration builds have changed state:
Travis build 4097. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/437942149.
Appveyor build 3893. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_bug_179433
Thanks for clarifying the TODO tags. I would expect the creator to be written
on the left and the assignee on the right of it.
The only way for this branch to slow down the game is if the ports and the
ships become hundreds. Even in that case, it should be lighter than the
previous code, so I d
Looks like my youtube video reminded you of something ;-)
Will check this now.
--
https://code.launchpad.net/~widelands-dev/widelands/fri-portraits/+merge/356221
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/fri-portraits into lp:wideland
Benedikt Straub has proposed merging lp:~widelands-dev/widelands/fri-portraits
into lp:widelands.
Commit message:
New portraits for the characters in the frisian campaign
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https://code.launchpad.net/~widelands-dev/w
* Source Package: widelands
* Version: 1:19-ppa0-bzr8869-201810060831~ubuntu14.04.1
* Architecture: amd64
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 3 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wi
* Source Package: widelands
* Version: 1:19-ppa0-bzr8869-201810060831~ubuntu14.04.1
* Architecture: i386
* Archive: ~widelands-dev/ubuntu/widelands-daily
* Component: main
* State: Failed to build
* Duration: 3 minutes
* Build Log:
https://launchpad.net/~widelands-dev/+archive/ubuntu/wid
The proposal to merge
lp:~widelands-dev/widelands/bug-1791426-multiplayer-map-change into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/bug-1791426-multiplayer-map-change/+merge/355622
--
Your team W
Review: Approve compile, review, test
Reproduced it on trunk, found it fixed here.
Looks like these monster switches in gameclient.cc deserve a refactoring :-)
One Comment inline.
All fine for me.
@bunnybot merge
Diff comments:
> === modified file 'src/network/gameclient.cc'
> --- src/networ
The proposal to merge lp:~widelands-dev/widelands/bug_1794339_center_wo_parent
into lp:widelands has been updated.
Description changed to:
Assert that Window has a parent instead of crashing.
Keep d->modal as parent window in GameClient::run() and set to nullptr as late
as possible. This shoul
The proposal to merge lp:~widelands-dev/widelands/bug_1794339_center_wo_parent
into lp:widelands has been updated.
Commit message changed to:
Assert null access in Window::center_to_parent(), keep parent window in
GameClient::run()
For more details, see:
https://code.launchpad.net/~widelands-d
16 matches
Mail list logo
